Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8333583: Crypto-XDH.generateSecret regression after JDK-8329538 #19895

Conversation

TobiHartmann
Copy link
Member

@TobiHartmann TobiHartmann commented Jun 26, 2024

Hi all,

This pull request contains a backport of commit f101e153 from the openjdk/jdk repository.

The commit being backported was authored by Volodymyr Paprotski on 25 Jun 2024 and was reviewed by Sandhya Viswanathan, Vladimir Kozlov and Anthony Scarpino.

Thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8333583: Crypto-XDH.generateSecret regression after JDK-8329538 (Bug - P3)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19895/head:pull/19895
$ git checkout pull/19895

Update a local copy of the PR:
$ git checkout pull/19895
$ git pull https://git.openjdk.org/jdk.git pull/19895/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19895

View PR using the GUI difftool:
$ git pr show -t 19895

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19895.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 26, 2024

👋 Welcome back thartmann! A progress list of the required criteria for merging this PR into jdk23 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 26, 2024

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

@openjdk openjdk bot changed the title Backport f101e153cee68750fcf1f12da10e29806875b522 8333583: Crypto-XDH.generateSecret regression after JDK-8329538 Jun 26, 2024
@openjdk
Copy link

openjdk bot commented Jun 26, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean rfr Pull request is ready for review labels Jun 26, 2024
@openjdk
Copy link

openjdk bot commented Jun 26, 2024

@TobiHartmann The following labels will be automatically applied to this pull request:

  • build
  • hotspot
  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added security security-dev@openjdk.org build build-dev@openjdk.org hotspot hotspot-dev@openjdk.org labels Jun 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport build build-dev@openjdk.org clean hotspot hotspot-dev@openjdk.org rfr Pull request is ready for review security security-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

1 participant