8334629: [BACKOUT] PhaseIdealLoop::conditional_move is too conservative

[TobiHartmann]

Hi all,

This pull request contains a backport of commit 933eabab from the openjdk/jdk repository.

The commit being backported was authored by Quan Anh Mai on 25 Jun 2024 and was reviewed by Emanuel Peter, Tobias Hartmann and Jasmine Karthikeyan.

Thanks!

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8334629: [BACKOUT] PhaseIdealLoop::conditional_move is too conservative (Sub-task - P3)

Reviewers

• Christian Hagedorn (@chhagedorn - Reviewer)
• Quan Anh Mai (@merykitty - Committer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19896/head:pull/19896
$ git checkout pull/19896

Update a local copy of the PR:
$ git checkout pull/19896
$ git pull https://git.openjdk.org/jdk.git pull/19896/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19896

View PR using the GUI difftool:
$ git pr show -t 19896

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19896.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back thartmann! A progress list of the required criteria for merging this PR into jdk23 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@TobiHartmann This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8334629: [BACKOUT] PhaseIdealLoop::conditional_move is too conservative

Reviewed-by: chagedorn, qamai

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the jdk23 branch:

• d151050: 8334594: Generational ZGC: Deadlock after OopMap rewrites in 8331572

Please see this link for an up-to-date comparison between the source branch of this pull request and the jdk23 branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the jdk23 branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

@TobiHartmann The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (edd27d5f)

[chhagedorn]

Looks good!

[TobiHartmann]

Thanks Christian!

[merykitty]

Thanks a lot for creating the backport

[TobiHartmann]

Thanks Quan Anh!

[TobiHartmann]

/integrate

[openjdk]

Going to push as commit 2086b0f.
Since your change was applied there has been 1 commit pushed to the jdk23 branch:

• d151050: 8334594: Generational ZGC: Deadlock after OopMap rewrites in 8331572

Your commit was automatically rebased without conflicts.

[openjdk]

@TobiHartmann Pushed as commit 2086b0f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.