Skip to content

Conversation

@albertnetymk
Copy link
Member

@albertnetymk albertnetymk commented Jun 26, 2024

Trivial extracting "copying" logic from old-gen-allocation method to unify the use of Copy and transform_stack_chunk in young-gc promotion path.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8335147: Serial: Refactor TenuredGeneration::promote (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19899/head:pull/19899
$ git checkout pull/19899

Update a local copy of the PR:
$ git checkout pull/19899
$ git pull https://git.openjdk.org/jdk.git pull/19899/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19899

View PR using the GUI difftool:
$ git pr show -t 19899

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19899.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 26, 2024

👋 Welcome back ayang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 26, 2024

@albertnetymk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8335147: Serial: Refactor TenuredGeneration::promote

Reviewed-by: tschatzl, iwalulya

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 4060b35: 8335298: Fix -Wzero-as-null-pointer-constant warning in G1CardSetContainers

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title 8335147 8335147: Serial: Refactor TenuredGeneration::promote Jun 26, 2024
@openjdk openjdk bot added the rfr Pull request is ready for review label Jun 26, 2024
@openjdk
Copy link

openjdk bot commented Jun 26, 2024

@albertnetymk The following label will be automatically applied to this pull request:

  • hotspot-gc

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Jun 26, 2024
@mlbridge
Copy link

mlbridge bot commented Jun 26, 2024

Webrevs

// The "obj_size" argument is just obj->size(), passed along so the caller can
// avoid repeating the virtual call to retrieve it.
oop promote(oop obj, size_t obj_size);
oop allocate_for_promotion(oop obj, size_t obj_size);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The first paragraph above needs to be adjusted to the new decreased functionality.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 2, 2024
@albertnetymk
Copy link
Member Author

Thanks for review.

/integrate

@openjdk
Copy link

openjdk bot commented Jul 2, 2024

Going to push as commit dd74e7f.
Since your change was applied there have been 2 commits pushed to the master branch:

  • a537e87: 8335530: Java file extension missing in AuthenticatorTest
  • 4060b35: 8335298: Fix -Wzero-as-null-pointer-constant warning in G1CardSetContainers

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 2, 2024
@openjdk openjdk bot closed this Jul 2, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 2, 2024
@openjdk
Copy link

openjdk bot commented Jul 2, 2024

@albertnetymk Pushed as commit dd74e7f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@albertnetymk albertnetymk deleted the s1-alloc-promote branch July 2, 2024 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants