Skip to content

8253220: Epsilon: clean up unused code/declarations #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

shipilev
Copy link
Member

@shipilev shipilev commented Sep 16, 2020

Static analysis reports a few instances of unused code.

Testing: Linux x86_64 fastdebug gc/epsilon


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8253220: Epsilon: clean up unused code/declarations

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/199/head:pull/199
$ git checkout pull/199

@bridgekeeper
Copy link

bridgekeeper bot commented Sep 16, 2020

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 16, 2020
@openjdk
Copy link

openjdk bot commented Sep 16, 2020

@shipilev The following label will be automatically applied to this pull request: hotspot-gc.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label (add|remove) "label" command.

@openjdk openjdk bot added the hotspot-gc hotspot-gc-dev@openjdk.org label Sep 16, 2020
@mlbridge
Copy link

mlbridge bot commented Sep 16, 2020

Webrevs

@openjdk
Copy link

openjdk bot commented Sep 16, 2020

@shipilev This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements

After integration, the commit message will be:

8253220: Epsilon: clean up unused code/declarations

Reviewed-by: tschatzl
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

Since the source branch of this PR was last updated there have been 3 commits pushed to the master branch:

  • e0cf023: 8245309: Re-examine use of ThreadLocalCoders in sun.net.www.ParseUtil
  • 60c4902: 8253016: Box.Filler components should be unfocusable by default
  • dd43533: 8253222: Shenandoah: unused AlwaysTrueClosure after JDK-8246591

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid automatic rebasing, please merge master into your branch, and then specify the current head hash when integrating, like this: /integrate e0cf023263fcd8ad5c8235828e025c5842807bfe.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 16, 2020
@mlbridge
Copy link

mlbridge bot commented Sep 16, 2020

Mailing list message from Thomas Schatzl on hotspot-gc-dev:

Hi,

On 16.09.20 10:00, Aleksey Shipilev wrote:

Static analysis shows a few #include statements in gc/epsilon that are not needed.

^^^---- please fix the description :) (copy&paste from the other issue)

lgtm and trivial.

Thomas

@shipilev
Copy link
Member Author

/integrate

@openjdk openjdk bot closed this Sep 16, 2020
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 16, 2020
@openjdk
Copy link

openjdk bot commented Sep 16, 2020

@shipilev Since your change was applied there have been 3 commits pushed to the master branch:

  • e0cf023: 8245309: Re-examine use of ThreadLocalCoders in sun.net.www.ParseUtil
  • 60c4902: 8253016: Box.Filler components should be unfocusable by default
  • dd43533: 8253222: Shenandoah: unused AlwaysTrueClosure after JDK-8246591

Your commit was automatically rebased without conflicts.

Pushed as commit 7f9b5d9.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8253220-epsilon-declarations branch September 16, 2020 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-gc hotspot-gc-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants