New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8259397: ThreadsSMRSupport::print_info_on() should use try_lock_without_rank_check() #1991
Conversation
/label hotspot-runtime |
|
@dcubed-ojdk |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! this should fix the issue I saw today.
@dcubed-ojdk This change now passes all automated pre-integration checks. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 29 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.
|
@coleenp - You're quite welcome. Thanks for the fast review! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Thanks,
David
@dholmes-ora - Thanks for the review. |
/integrate |
@dcubed-ojdk Since your change was applied there have been 34 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 090bd3a. |
This is a trivial fix to use try_lock_without_rank_check() instead of try_lock()
in ThreadsSMRSupport::print_info_on().
I've locally built and tested this fix on my MBP13. It will be included in my
next Mach5 Tier[1-3] testing batch.
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/1991/head:pull/1991
$ git checkout pull/1991