Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8259397: ThreadsSMRSupport::print_info_on() should use try_lock_without_rank_check() #1991

Closed
wants to merge 1 commit into from

Conversation

dcubed-ojdk
Copy link
Member

@dcubed-ojdk dcubed-ojdk commented Jan 7, 2021

This is a trivial fix to use try_lock_without_rank_check() instead of try_lock()
in ThreadsSMRSupport::print_info_on().

I've locally built and tested this fix on my MBP13. It will be included in my
next Mach5 Tier[1-3] testing batch.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8259397: ThreadsSMRSupport::print_info_on() should use try_lock_without_rank_check()

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/1991/head:pull/1991
$ git checkout pull/1991

@dcubed-ojdk
Copy link
Member Author

/label hotspot-runtime

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 7, 2021

👋 Welcome back dcubed! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Jan 7, 2021
@openjdk
Copy link

openjdk bot commented Jan 7, 2021

@dcubed-ojdk
The hotspot-runtime label was successfully added.

@dcubed-ojdk dcubed-ojdk marked this pull request as ready for review January 7, 2021 22:24
@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 7, 2021
@mlbridge
Copy link

mlbridge bot commented Jan 7, 2021

Webrevs

Copy link
Contributor

@coleenp coleenp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! this should fix the issue I saw today.

@openjdk
Copy link

openjdk bot commented Jan 7, 2021

@dcubed-ojdk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8259397: ThreadsSMRSupport::print_info_on() should use try_lock_without_rank_check()

Reviewed-by: coleenp, dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 29 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 7, 2021
@dcubed-ojdk
Copy link
Member Author

@coleenp - You're quite welcome. Thanks for the fast review!

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Thanks,
David

@dcubed-ojdk
Copy link
Member Author

@dholmes-ora - Thanks for the review.

@dcubed-ojdk
Copy link
Member Author

/integrate

@openjdk openjdk bot closed this Jan 8, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 8, 2021
@dcubed-ojdk dcubed-ojdk deleted the JDK-8259397 branch January 8, 2021 15:30
@openjdk
Copy link

openjdk bot commented Jan 8, 2021

@dcubed-ojdk Since your change was applied there have been 34 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

Pushed as commit 090bd3a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
3 participants