8335134: Test com/sun/jdi/BreakpointOnClassPrepare.java timeout

[plummercj]

Allow ObjectCollectedException during ThreadReference.toString() call. This can happen when using SUSPEND_NONE since the thread continues to run after hitting the breakpoint.

So far I've just run the test locally. I'll run the full suite of debugger tests before committing. Note I don't know how to reproduce the filed issue. We have not seen this turn up in our CI yet, but theoretically the ObjectCollectedException can happen.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8335134: Test com/sun/jdi/BreakpointOnClassPrepare.java timeout (Bug - P3)

Reviewers

• Kevin Walls (@kevinjwalls - Reviewer)
• Coleen Phillimore (@coleenp - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19910/head:pull/19910
$ git checkout pull/19910

Update a local copy of the PR:
$ git checkout pull/19910
$ git pull https://git.openjdk.org/jdk.git pull/19910/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19910

View PR using the GUI difftool:
$ git pr show -t 19910

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19910.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back cjplummer! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@plummercj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8335134: Test com/sun/jdi/BreakpointOnClassPrepare.java timeout

Reviewed-by: kevinw, coleenp

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 22 new commits pushed to the master branch:

• 243bae7: 8304693: Remove -XX:-UseVtableBasedCHA
• 9d986a0: 8335220: C2: Missing check for Opaque4 node in EscapeAnalysis
• 0e6b0cb: 8334886: jdk/jfr/api/recording/time/TestTimeMultiple.java failed with RuntimeException: getStopTime() > afterStop
• b6ffb44: 8335135: HttpURLConnection#HttpInputStream does not throw IOException when response is truncated
• 4ab7e98: 8330842: Support AES CBC with Ciphertext Stealing (CTS) in SunPKCS11
• 5909d54: 8326820: Metadata artificially kept alive
• d5375c7: 8333308: javap --system handling doesn't work on internal class names
• 6b961ac: 8333786: Serial: Remove SerialHeap::_incremental_collection_failed
• 50dd962: 8335007: Inline OopMapCache table
• 79a2301: 8322859: Parallel: Move transform_stack_chunk
• ... and 12 more: https://git.openjdk.org/jdk/compare/b5d589623c174757e946011495f771718318f1cc...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@plummercj The following label will be automatically applied to this pull request:

• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (4161fa3f)

[kevinjwalls]

looks good

[coleenp]

This looks good.

[plummercj]

Thanks for the reviews Kevin and Coleen!

/integrate

[openjdk]

@plummercj Unknown command intergrate - for a list of valid commands use /help.

[plummercj]

/integrate

[openjdk]

Going to push as commit 4e8cbf8.
Since your change was applied there have been 24 commits pushed to the master branch:

• 3b1ca98: 8334895: OpenJDK fails to configure on linux aarch64 when CDS is disabled after JDK-8331942
• c35e58a: 8309634: Resolve CONSTANT_MethodRef at CDS dump time
• 243bae7: 8304693: Remove -XX:-UseVtableBasedCHA
• 9d986a0: 8335220: C2: Missing check for Opaque4 node in EscapeAnalysis
• 0e6b0cb: 8334886: jdk/jfr/api/recording/time/TestTimeMultiple.java failed with RuntimeException: getStopTime() > afterStop
• b6ffb44: 8335135: HttpURLConnection#HttpInputStream does not throw IOException when response is truncated
• 4ab7e98: 8330842: Support AES CBC with Ciphertext Stealing (CTS) in SunPKCS11
• 5909d54: 8326820: Metadata artificially kept alive
• d5375c7: 8333308: javap --system handling doesn't work on internal class names
• 6b961ac: 8333786: Serial: Remove SerialHeap::_incremental_collection_failed
• ... and 14 more: https://git.openjdk.org/jdk/compare/b5d589623c174757e946011495f771718318f1cc...master

Your commit was automatically rebased without conflicts.

[openjdk]

@plummercj Pushed as commit 4e8cbf8.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.