8335142: compiler/c1/TestTraceLinearScanLevel.java occasionally times out with -Xcomp

[chhagedorn]

The testcompiler/c1/TestTraceLinearScanLevel.java is occasionally timing out on macosx-x64 when running with -Xcomp. The test's purpose is to sanity check the TraceLinearScanLevel flag with a hello world like test. It runs with the highest level which prints quite a lot of data which takes time. It becomes even worse when running with -Xcomp. Since we only want to sanity check the flag, there is not that much benefit in additionally running this test with -Xcomp. This only unnecessarily increases the time to run this test.

I therefore exclude the test from running with -Xcomp. As a trade-off, I added -Xbatch to at least cover all the C1 compiled methods from start-up.

Thanks,
Christian

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8335142: compiler/c1/TestTraceLinearScanLevel.java occasionally times out with -Xcomp (Bug - P5)

Reviewers

• Tobias Hartmann (@TobiHartmann - Reviewer)
• Vladimir Kozlov (@vnkozlov - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19923/head:pull/19923
$ git checkout pull/19923

Update a local copy of the PR:
$ git checkout pull/19923
$ git pull https://git.openjdk.org/jdk.git pull/19923/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19923

View PR using the GUI difftool:
$ git pr show -t 19923

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19923.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back chagedorn! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@chhagedorn This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8335142: compiler/c1/TestTraceLinearScanLevel.java occasionally times out with -Xcomp

Reviewed-by: thartmann, kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 29 new commits pushed to the master branch:

• 5909d54: 8326820: Metadata artificially kept alive
• d5375c7: 8333308: javap --system handling doesn't work on internal class names
• 6b961ac: 8333786: Serial: Remove SerialHeap::_incremental_collection_failed
• 50dd962: 8335007: Inline OopMapCache table
• 79a2301: 8322859: Parallel: Move transform_stack_chunk
• 37e7698: 8335154: jcmd VM.classes -verbose=false does not set verbose to false
• f3b69da: 8335136: Underscore as parameter name in one-parameter functional types fails to compile
• 46b817b: 8333363: ubsan: instanceKlass.cpp: runtime error: member call on null pointer of type 'struct AnnotationArray'
• 0fc5b27: 8332014: since-checker - Fix @ since tags in jdk.jshell
• 9d20b58: 8334328: Reduce object allocation for FloatToDecimal and DoubleToDecimal
• ... and 19 more: https://git.openjdk.org/jdk/compare/b88af94269640a160fbacf25618f3a00756464aa...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@chhagedorn The following label will be automatically applied to this pull request:

• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (fbab3847)

[TobiHartmann]

Good and trivial.

[vnkozlov]

Good.

[chhagedorn]

Thanks Tobias and Vladimir for your reviews!

/integrate

[openjdk]

Going to push as commit 6f4ddc2.
Since your change was applied there have been 43 commits pushed to the master branch:

• 3b3a19e: 8335314: Problem list compiler/uncommontrap/DeoptReallocFailure.java
• d457609: 8319947: Recursive lightweight locking: s390x implementation
• c47a0e0: 8334147: Shenandoah: Avoid taking lock for disabled free set logging
• 308a812: 8334645: Un-problemlist vmTestbase/nsk/sysdict/vm/stress/chain/chain007/chain007.java
• b4df380: 8334763: --enable-asan: assert(_thread->is_in_live_stack((address)this)) failed: not on stack?
• cd46c87: 8334843: RISC-V: Fix wraparound checking for r_array_index in lookup_secondary_supers_table_slow_path
• 4e8cbf8: 8335134: Test com/sun/jdi/BreakpointOnClassPrepare.java timeout
• 3b1ca98: 8334895: OpenJDK fails to configure on linux aarch64 when CDS is disabled after JDK-8331942
• c35e58a: 8309634: Resolve CONSTANT_MethodRef at CDS dump time
• 243bae7: 8304693: Remove -XX:-UseVtableBasedCHA
• ... and 33 more: https://git.openjdk.org/jdk/compare/b88af94269640a160fbacf25618f3a00756464aa...master

Your commit was automatically rebased without conflicts.

[openjdk]

@chhagedorn Pushed as commit 6f4ddc2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.