Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8269657: Test java/nio/channels/DatagramChannel/Loopback.java failed: Unexpected message #19936

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Jun 28, 2024

Hi all,

This pull request contains a backport of commit c798316b from the openjdk/jdk repository.

The commit being backported was authored by SendaoYan on 28 Jun 2024 and was reviewed by Daniel Fuchs.

Thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8269657: Test java/nio/channels/DatagramChannel/Loopback.java failed: Unexpected message (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19936/head:pull/19936
$ git checkout pull/19936

Update a local copy of the PR:
$ git checkout pull/19936
$ git pull https://git.openjdk.org/jdk.git pull/19936/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19936

View PR using the GUI difftool:
$ git pr show -t 19936

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19936.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 28, 2024

👋 Welcome back syan! A progress list of the required criteria for merging this PR into jdk23 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 28, 2024

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8269657: Test java/nio/channels/DatagramChannel/Loopback.java failed: Unexpected message

Reviewed-by: jpai

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 34 new commits pushed to the jdk23 branch:

  • d7b7c17: 8335409: Can't allocate and retain memory from resource area in frame::oops_interpreted_do oop closure after 8329665
  • 5162e1a: 8334653: ISO 4217 Amendment 177 Update
  • 908d1e9: 8336259: Wrong link to stylesheet.css in JavaDoc API documentation
  • fd38606: 8325369: @sealedGraph: Bad link to image for tag on nested classes
  • a106e52: 8324841: PKCS11 tests still skip execution
  • 52cd9bb: 8335820: java/lang/invoke/LFCaching/LFSingleThreadCachingTest.java fails due to IllegalArgumentException: hash must be nonzero
  • 7cc50a1: 8334719: (se) Deferred close of SelectableChannel may result in a Selector doing the final close before concurrent I/O on channel has completed
  • cfbfe4a: 8318106: Generated HTML for snippet does not always contain an id
  • d1373a2: 8336036: Synthetic documentation for a record's equals is incorrect for floating-point types
  • 0a9e3bf: 8334418: Update IANA Language Subtag Registry to Version 2024-06-14
  • ... and 24 more: https://git.openjdk.org/jdk/compare/32ed61572c44024b4516e42c1b1b6557a3f953fd...jdk23

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jaikiran) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport c798316bc4cb33fd902f926030d8a0b6870d661a 8269657: Test java/nio/channels/DatagramChannel/Loopback.java failed: Unexpected message Jun 28, 2024
@openjdk
Copy link

openjdk bot commented Jun 28, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added the backport label Jun 28, 2024
@sendaoYan
Copy link
Member Author

/approval request Backport to jdk23 to fix the test intermittent failure, only change the testcase, no risk.

@openjdk openjdk bot added clean rfr Pull request is ready for review labels Jun 28, 2024
@openjdk
Copy link

openjdk bot commented Jun 28, 2024

@sendaoYan Changes in this repository do not require maintainer approval.

@openjdk
Copy link

openjdk bot commented Jun 28, 2024

@sendaoYan The following label will be automatically applied to this pull request:

  • nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the nio nio-dev@openjdk.org label Jun 28, 2024
@mlbridge
Copy link

mlbridge bot commented Jun 28, 2024

Webrevs

@sendaoYan
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jul 16, 2024

@sendaoYan This pull request has not yet been marked as ready for integration.

@sendaoYan
Copy link
Member Author

sendaoYan commented Jul 16, 2024

Clean backport from jdk mainline to jdk23, can anyone take look this PR.

@sendaoYan
Copy link
Member Author

Clean backport to fix the testcase bug and solve the intermittent failure, no risk.

Copy link
Member

@jaikiran jaikiran left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a clean backport of a test-only fix that was integrated into master branch 3 weeks back. Looks OK to me for JDK 23.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 17, 2024
@sendaoYan
Copy link
Member Author

is a clean backport of a test-only fix that was integrated into master

Thanks for the review.
/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jul 17, 2024
@openjdk
Copy link

openjdk bot commented Jul 17, 2024

@sendaoYan
Your change (at version 68e34cc) is now ready to be sponsored by a Committer.

@jaikiran
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Jul 17, 2024

Going to push as commit 024b39c.
Since your change was applied there have been 44 commits pushed to the jdk23 branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 17, 2024
@openjdk openjdk bot closed this Jul 17, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jul 17, 2024
@openjdk
Copy link

openjdk bot commented Jul 17, 2024

@jaikiran @sendaoYan Pushed as commit 024b39c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@sendaoYan
Copy link
Member Author

Thanks for the sponsor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated nio nio-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

2 participants