-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8269657: Test java/nio/channels/DatagramChannel/Loopback.java failed: Unexpected message #19936
8269657: Test java/nio/channels/DatagramChannel/Loopback.java failed: Unexpected message #19936
Conversation
👋 Welcome back syan! A progress list of the required criteria for merging this PR into |
@sendaoYan This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 34 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@jaikiran) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
This backport pull request has now been updated with issue from the original commit. |
/approval request Backport to jdk23 to fix the test intermittent failure, only change the testcase, no risk. |
@sendaoYan Changes in this repository do not require maintainer approval. |
@sendaoYan The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
/integrate |
@sendaoYan This pull request has not yet been marked as ready for integration. |
Clean backport from jdk mainline to jdk23, can anyone take look this PR. |
Clean backport to fix the testcase bug and solve the intermittent failure, no risk. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a clean backport of a test-only fix that was integrated into master branch 3 weeks back. Looks OK to me for JDK 23.
Thanks for the review. |
@sendaoYan |
/sponsor |
Going to push as commit 024b39c.
Your commit was automatically rebased without conflicts. |
@jaikiran @sendaoYan Pushed as commit 024b39c. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Thanks for the sponsor. |
Hi all,
This pull request contains a backport of commit c798316b from the openjdk/jdk repository.
The commit being backported was authored by SendaoYan on 28 Jun 2024 and was reviewed by Daniel Fuchs.
Thanks!
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19936/head:pull/19936
$ git checkout pull/19936
Update a local copy of the PR:
$ git checkout pull/19936
$ git pull https://git.openjdk.org/jdk.git pull/19936/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 19936
View PR using the GUI difftool:
$ git pr show -t 19936
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19936.diff
Webrev
Link to Webrev Comment