Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8334600: TEST java/net/MulticastSocket/IPMulticastIF.java fails on linux-aarch64 #19945

Conversation

sendaoYan
Copy link
Member

@sendaoYan sendaoYan commented Jun 28, 2024

Hi all,

This pull request contains a backport of commit f23295ec from the openjdk/jdk repository.

The commit being backported was authored by Daniel Fuchs on 26 Jun 2024 and was reviewed by Alan Bateman.

Thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8334600: TEST java/net/MulticastSocket/IPMulticastIF.java fails on linux-aarch64 (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19945/head:pull/19945
$ git checkout pull/19945

Update a local copy of the PR:
$ git checkout pull/19945
$ git pull https://git.openjdk.org/jdk.git pull/19945/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19945

View PR using the GUI difftool:
$ git pr show -t 19945

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19945.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jun 28, 2024

👋 Welcome back syan! A progress list of the required criteria for merging this PR into jdk23 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jun 28, 2024

@sendaoYan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8334600: TEST java/net/MulticastSocket/IPMulticastIF.java fails on linux-aarch64

Reviewed-by: clanger

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the jdk23 branch:

  • 7040de1: 8333542: Breakpoint in parallel code does not work
  • e5fbc63: 8326820: Metadata artificially kept alive
  • e78c682: 8333849: (dc) DatagramChannel send/receive fails with UOE if buffer backed by memory segment allocated from shared arena
  • 87a2962: 8335220: C2: Missing check for Opaque4 node in EscapeAnalysis

Please see this link for an up-to-date comparison between the source branch of this pull request and the jdk23 branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@RealCLanger) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot changed the title Backport f23295ec1dde58d239a2625c9b1645534a2bb625 8334600: TEST java/net/MulticastSocket/IPMulticastIF.java fails on linux-aarch64 Jun 28, 2024
@openjdk
Copy link

openjdk bot commented Jun 28, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean rfr Pull request is ready for review labels Jun 28, 2024
@openjdk
Copy link

openjdk bot commented Jun 28, 2024

@sendaoYan The following label will be automatically applied to this pull request:

  • net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the net net-dev@openjdk.org label Jun 28, 2024
@mlbridge
Copy link

mlbridge bot commented Jun 28, 2024

Webrevs

@AlanBateman
Copy link
Contributor

@dfuch Has you planned to backport this to jdk23?

@sendaoYan
Copy link
Member Author

@dfuch Has you planned to backport this to jdk23?

Before backport to jdk17u-dev and jdk21u-dev, should we backport to jdk23 first.

@RealCLanger
Copy link
Contributor

It's a test fix, so I guess it should be fine to bring to jdk23. If not, we shall do it at least in jdk23u.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 1, 2024
@sendaoYan
Copy link
Member Author

Thanks for the review.
/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jul 1, 2024
@openjdk
Copy link

openjdk bot commented Jul 1, 2024

@sendaoYan
Your change (at version d31e139) is now ready to be sponsored by a Committer.

@dfuch
Copy link
Member

dfuch commented Jul 1, 2024

/sponsor

@openjdk
Copy link

openjdk bot commented Jul 1, 2024

Going to push as commit 4410cdc.
Since your change was applied there have been 4 commits pushed to the jdk23 branch:

  • 7040de1: 8333542: Breakpoint in parallel code does not work
  • e5fbc63: 8326820: Metadata artificially kept alive
  • e78c682: 8333849: (dc) DatagramChannel send/receive fails with UOE if buffer backed by memory segment allocated from shared arena
  • 87a2962: 8335220: C2: Missing check for Opaque4 node in EscapeAnalysis

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 1, 2024
@openjdk openjdk bot closed this Jul 1, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jul 1, 2024
@openjdk
Copy link

openjdk bot commented Jul 1, 2024

@dfuch @sendaoYan Pushed as commit 4410cdc.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@sendaoYan
Copy link
Member Author

Thanks for the sponsor.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated net net-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

4 participants