-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8335134: Test com/sun/jdi/BreakpointOnClassPrepare.java timeout #19976
8335134: Test com/sun/jdi/BreakpointOnClassPrepare.java timeout #19976
Conversation
👋 Welcome back cjplummer! A progress list of the required criteria for merging this PR into |
@plummercj This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the ➡️ To integrate this PR with the above commit message to the |
This backport pull request has now been updated with issue from the original commit. |
@plummercj The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Backport looks accurate.
Thanks
Thanks David! Integrating now since without this backport we might start seeing some new CI failures due to JDK-8333542 having been backported earlier today. /integrate |
Going to push as commit 9d744b0. |
@plummercj Pushed as commit 9d744b0. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Clean backport. Need to backport this since it was introduced with the new test in JDK-8333542, which has also been backpoted to 23.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19976/head:pull/19976
$ git checkout pull/19976
Update a local copy of the PR:
$ git checkout pull/19976
$ git pull https://git.openjdk.org/jdk.git pull/19976/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 19976
View PR using the GUI difftool:
$ git pr show -t 19976
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19976.diff
Webrev
Link to Webrev Comment