Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8335134: Test com/sun/jdi/BreakpointOnClassPrepare.java timeout #19976

Conversation

plummercj
Copy link
Contributor

@plummercj plummercj commented Jul 1, 2024

Clean backport. Need to backport this since it was introduced with the new test in JDK-8333542, which has also been backpoted to 23.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8335134: Test com/sun/jdi/BreakpointOnClassPrepare.java timeout (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/19976/head:pull/19976
$ git checkout pull/19976

Update a local copy of the PR:
$ git checkout pull/19976
$ git pull https://git.openjdk.org/jdk.git pull/19976/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 19976

View PR using the GUI difftool:
$ git pr show -t 19976

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/19976.diff

Webrev

Link to Webrev Comment

@plummercj plummercj marked this pull request as ready for review July 1, 2024 17:10
@bridgekeeper
Copy link

bridgekeeper bot commented Jul 1, 2024

👋 Welcome back cjplummer! A progress list of the required criteria for merging this PR into jdk23 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 1, 2024

@plummercj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8335134: Test com/sun/jdi/BreakpointOnClassPrepare.java timeout

Reviewed-by: dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the jdk23 branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the jdk23 branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 4e8cbf884ab1eee9c3110712ab62edc706e948ba 8335134: Test com/sun/jdi/BreakpointOnClassPrepare.java timeout Jul 1, 2024
@openjdk
Copy link

openjdk bot commented Jul 1, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean rfr Pull request is ready for review labels Jul 1, 2024
@openjdk
Copy link

openjdk bot commented Jul 1, 2024

@plummercj The following label will be automatically applied to this pull request:

  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the serviceability serviceability-dev@openjdk.org label Jul 1, 2024
@mlbridge
Copy link

mlbridge bot commented Jul 1, 2024

Webrevs

Copy link
Member

@dholmes-ora dholmes-ora left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Backport looks accurate.

Thanks

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 1, 2024
@plummercj
Copy link
Contributor Author

Thanks David!

Integrating now since without this backport we might start seeing some new CI failures due to JDK-8333542 having been backported earlier today.

/integrate

@openjdk
Copy link

openjdk bot commented Jul 1, 2024

Going to push as commit 9d744b0.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 1, 2024
@openjdk openjdk bot closed this Jul 1, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 1, 2024
@openjdk
Copy link

openjdk bot commented Jul 1, 2024

@plummercj Pushed as commit 9d744b0.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean integrated Pull request has been integrated serviceability serviceability-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

2 participants