Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8259446: runtime/jni/checked/TestCheckedReleaseArrayElements.java fails with stderr not empty #2001

Closed
wants to merge 2 commits into from

Conversation

dholmes-ora
Copy link
Member

@dholmes-ora dholmes-ora commented Jan 8, 2021

The test checks stderr is empty.
The test is run in our tier3 CI testing.
Tier3 (and some other tiers) has a configuration that includes the -showversion flag which outputs the version string to stderr.

=> ergo the test fails because stderr is not empty!

Fix: exec the secondary VM without including the jtreg test VM arguments.

I think this is really a bug in our test job definitions and we've been very lucky to not encounter problems with using -showversion, but as a quick fix this suffices, and we don't expect any other JVM flags to have any impact here.

Tested by running jtreg with/without -showversion being passed to JVM under test.
Tier3 test run in progress too.
Thanks.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8259446: runtime/jni/checked/TestCheckedReleaseArrayElements.java fails with stderr not empty

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2001/head:pull/2001
$ git checkout pull/2001

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 8, 2021

👋 Welcome back dholmes! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 8, 2021
@openjdk
Copy link

openjdk bot commented Jan 8, 2021

@dholmes-ora The following label will be automatically applied to this pull request:

  • hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-runtime hotspot-runtime-dev@openjdk.org label Jan 8, 2021
@mlbridge
Copy link

mlbridge bot commented Jan 8, 2021

Webrevs

@dholmes-ora
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jan 8, 2021

@dholmes-ora This PR has not yet been marked as ready for integration.

Copy link
Member

@dcubed-ojdk dcubed-ojdk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thumbs up! Also, this is a trivial change.

@openjdk
Copy link

openjdk bot commented Jan 8, 2021

@dholmes-ora This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8259446: runtime/jni/checked/TestCheckedReleaseArrayElements.java fails with stderr not empty

Reviewed-by: dcubed

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 8 new commits pushed to the master branch:

  • 628c546: 8258796: [test] Apply HexFormat to tests for java.security
  • 876c7fb: 8259493: [test] Use HexFormat instead of adhoc hex utilities in network code and locale SoftKeys
  • 090bd3a: 8259397: ThreadsSMRSupport::print_info_on() should use try_lock_without_rank_check()
  • 10a6b0d: 8234773: Fix ThreadsSMRSupport::_bootstrap_list
  • 6f7723b: 8258792: LogCompilation: remove redundant check fixed by 8257518
  • 697bf7a: 8257740: Compiler crash when compiling type annotation on multicatch inside lambda
  • b549cbd: 8258481: gc.g1.plab.TestPLABPromotion fails on Linux x86
  • fc1d2a1: 8259065: Optimize MessageDigest.getInstance

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 8, 2021
@dholmes-ora
Copy link
Member Author

/integrate

@openjdk openjdk bot closed this Jan 8, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 8, 2021
@dholmes-ora dholmes-ora deleted the 8259446 branch January 8, 2021 22:25
@openjdk
Copy link

openjdk bot commented Jan 8, 2021

@dholmes-ora Since your change was applied there have been 8 commits pushed to the master branch:

  • 628c546: 8258796: [test] Apply HexFormat to tests for java.security
  • 876c7fb: 8259493: [test] Use HexFormat instead of adhoc hex utilities in network code and locale SoftKeys
  • 090bd3a: 8259397: ThreadsSMRSupport::print_info_on() should use try_lock_without_rank_check()
  • 10a6b0d: 8234773: Fix ThreadsSMRSupport::_bootstrap_list
  • 6f7723b: 8258792: LogCompilation: remove redundant check fixed by 8257518
  • 697bf7a: 8257740: Compiler crash when compiling type annotation on multicatch inside lambda
  • b549cbd: 8258481: gc.g1.plab.TestPLABPromotion fails on Linux x86
  • fc1d2a1: 8259065: Optimize MessageDigest.getInstance

Your commit was automatically rebased without conflicts.

Pushed as commit 7e6677b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants