-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8259446: runtime/jni/checked/TestCheckedReleaseArrayElements.java fails with stderr not empty #2001
Conversation
…ls with stderr not empty
👋 Welcome back dholmes! A progress list of the required criteria for merging this PR into |
@dholmes-ora The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
test/hotspot/jtreg/runtime/jni/checked/TestCheckedReleaseArrayElements.java
Show resolved
Hide resolved
/integrate |
@dholmes-ora This PR has not yet been marked as ready for integration. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thumbs up! Also, this is a trivial change.
@dholmes-ora This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 8 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
/integrate |
@dholmes-ora Since your change was applied there have been 8 commits pushed to the
Your commit was automatically rebased without conflicts. Pushed as commit 7e6677b. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
The test checks stderr is empty.
The test is run in our tier3 CI testing.
Tier3 (and some other tiers) has a configuration that includes the -showversion flag which outputs the version string to stderr.
=> ergo the test fails because stderr is not empty!
Fix: exec the secondary VM without including the jtreg test VM arguments.
I think this is really a bug in our test job definitions and we've been very lucky to not encounter problems with using
-showversion
, but as a quick fix this suffices, and we don't expect any other JVM flags to have any impact here.Tested by running jtreg with/without -showversion being passed to JVM under test.
Tier3 test run in progress too.
Thanks.
Progress
Issue
Reviewers
Download
$ git fetch https://git.openjdk.java.net/jdk pull/2001/head:pull/2001
$ git checkout pull/2001