Skip to content

8335532: [JVMCI] Export VM_Version::L1_line_size in JVMCI #20024

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

mur47x111
Copy link
Contributor

@mur47x111 mur47x111 commented Jul 4, 2024

This PR allows JVMCI compiler to implement lock add instruction same as Assembler::membar.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8335532: [JVMCI] Export VM_Version::L1_line_size in JVMCI (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20024/head:pull/20024
$ git checkout pull/20024

Update a local copy of the PR:
$ git checkout pull/20024
$ git pull https://git.openjdk.org/jdk.git pull/20024/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 20024

View PR using the GUI difftool:
$ git pr show -t 20024

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20024.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 4, 2024

👋 Welcome back yzheng! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 4, 2024

@mur47x111 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8335532: [JVMCI] Export VM_Version::L1_line_size in JVMCI

Reviewed-by: dnsimon

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 17 new commits pushed to the master branch:

  • c0604fb: 8334890: Missing unconditional cross modifying fence in nmethod entry barriers
  • cf1be87: 8335663: Fix simple -Wzero-as-null-pointer-constant warnings in C2 code
  • 0bb9c76: 8324089: Fix typo in the manual page for "jcmd" (man jcmd)
  • 3e3f83f: 8335385: javac crash on unattributed piece of AST
  • b20e8c8: 8335397: Improve reliability of TestRecursiveMonitorChurn.java
  • 38a578d: 8334738: os::print_hex_dump should optionally print ASCII
  • 7b894bc: 8332786: When dumping static CDS archives, explicitly assert that we don't use a CDS archive
  • e01626c: 8335655: ProblemList serviceability/dcmd/vm tests failing after JDK-8322475
  • 3efa93b: 8335588: Fix -Wzero-as-null-pointer-constant warnings in calls to Node ctor
  • 587535c: 8334545: runtime/ClassInitErrors/TestStackOverflowDuringInit.java fails after JDK-8294960
  • ... and 7 more: https://git.openjdk.org/jdk/compare/6923a5114b2a9f02f0d6f0fefc21141ac3b9322a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 4, 2024
@openjdk
Copy link

openjdk bot commented Jul 4, 2024

@mur47x111 The following labels will be automatically applied to this pull request:

  • graal
  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added graal graal-dev@openjdk.org hotspot-compiler hotspot-compiler-dev@openjdk.org labels Jul 4, 2024
@mlbridge
Copy link

mlbridge bot commented Jul 4, 2024

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 4, 2024
@mur47x111
Copy link
Contributor Author

Thanks for the review!

/integrate

@openjdk
Copy link

openjdk bot commented Jul 4, 2024

Going to push as commit 916db07.
Since your change was applied there have been 17 commits pushed to the master branch:

  • c0604fb: 8334890: Missing unconditional cross modifying fence in nmethod entry barriers
  • cf1be87: 8335663: Fix simple -Wzero-as-null-pointer-constant warnings in C2 code
  • 0bb9c76: 8324089: Fix typo in the manual page for "jcmd" (man jcmd)
  • 3e3f83f: 8335385: javac crash on unattributed piece of AST
  • b20e8c8: 8335397: Improve reliability of TestRecursiveMonitorChurn.java
  • 38a578d: 8334738: os::print_hex_dump should optionally print ASCII
  • 7b894bc: 8332786: When dumping static CDS archives, explicitly assert that we don't use a CDS archive
  • e01626c: 8335655: ProblemList serviceability/dcmd/vm tests failing after JDK-8322475
  • 3efa93b: 8335588: Fix -Wzero-as-null-pointer-constant warnings in calls to Node ctor
  • 587535c: 8334545: runtime/ClassInitErrors/TestStackOverflowDuringInit.java fails after JDK-8294960
  • ... and 7 more: https://git.openjdk.org/jdk/compare/6923a5114b2a9f02f0d6f0fefc21141ac3b9322a...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 4, 2024
@openjdk openjdk bot closed this Jul 4, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 4, 2024
@openjdk
Copy link

openjdk bot commented Jul 4, 2024

@mur47x111 Pushed as commit 916db07.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
graal graal-dev@openjdk.org hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants