Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8335479: JFR: Missing documentation for -XX:StartFlightRecording #20029

Closed

Conversation

egahlin
Copy link
Member

@egahlin egahlin commented Jul 4, 2024


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8335479: JFR: Missing documentation for -XX:StartFlightRecording (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20029/head:pull/20029
$ git checkout pull/20029

Update a local copy of the PR:
$ git checkout pull/20029
$ git pull https://git.openjdk.org/jdk.git pull/20029/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 20029

View PR using the GUI difftool:
$ git pr show -t 20029

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20029.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 4, 2024

👋 Welcome back egahlin! A progress list of the required criteria for merging this PR into jdk23 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 4, 2024

@egahlin This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8335479: JFR: Missing documentation for -XX:StartFlightRecording

Reviewed-by: mgronlun

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the jdk23 branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the jdk23 branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 68ffec9800b798927a050900a2d47000aa18ef30 8335479: JFR: Missing documentation for -XX:StartFlightRecording Jul 4, 2024
@openjdk
Copy link

openjdk bot commented Jul 4, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jul 4, 2024

@egahlin To determine the appropriate audience for reviewing this pull request, one or more labels corresponding to different subsystems will normally be applied automatically. However, no automatic labelling rule matches the changes in this pull request. In order to have an "RFR" email sent to the correct mailing list, you will need to add one or more applicable labels manually using the /label pull request command.

Applicable Labels
  • build
  • client
  • compiler
  • core-libs
  • graal
  • hotspot
  • hotspot-compiler
  • hotspot-gc
  • hotspot-jfr
  • hotspot-runtime
  • i18n
  • ide-support
  • javadoc
  • jdk
  • jmx
  • kulla
  • net
  • nio
  • security
  • serviceability
  • shenandoah

@egahlin
Copy link
Member Author

egahlin commented Jul 4, 2024

/label add hotspot-jfr

@openjdk openjdk bot added the hotspot-jfr hotspot-jfr-dev@openjdk.org label Jul 4, 2024
@openjdk
Copy link

openjdk bot commented Jul 4, 2024

@egahlin
The hotspot-jfr label was successfully added.

@egahlin egahlin marked this pull request as ready for review July 4, 2024 11:37
@openjdk openjdk bot added ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 4, 2024
@mlbridge
Copy link

mlbridge bot commented Jul 4, 2024

Webrevs

@egahlin
Copy link
Member Author

egahlin commented Jul 5, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Jul 5, 2024

Going to push as commit 653c481.
Since your change was applied there have been 2 commits pushed to the jdk23 branch:

  • 10b28ba: 8322812: Manpage for jcmd is missing JFR.view command
  • d383365: 8334890: Missing unconditional cross modifying fence in nmethod entry barriers

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 5, 2024
@openjdk openjdk bot closed this Jul 5, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 5, 2024
@openjdk
Copy link

openjdk bot commented Jul 5, 2024

@egahlin Pushed as commit 653c481.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean hotspot-jfr hotspot-jfr-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants