Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

8225045: javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java fails on linux-x64 #2003

Closed
wants to merge 2 commits into from
Closed

8225045: javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java fails on linux-x64 #2003

wants to merge 2 commits into from

Conversation

prsadhuk
Copy link
Contributor

@prsadhuk prsadhuk commented Jan 8, 2021 •
edited by openjdk bot

This test was failing on mach5 nightly on ubuntu systems long time back. Modified the test to add some delays and call robot.waitForIdle() to make it more stable and the resultant test passes on all mach5 systems including linux consisting of ubuntu 19.10, 18.04,20.10,20.04 so we can remove the test from problemlist.
mach5 job running for several iterations is posted in JBS.

Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8225045: javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java fails on linux-x64

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2003/head:pull/2003
$ git checkout pull/2003

@bridgekeeper
Copy link

bridgekeeper bot commented Jan 8, 2021

👋 Welcome back psadhukhan! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jan 8, 2021
@openjdk
Copy link

openjdk bot commented Jan 8, 2021

@prsadhuk The following label will be automatically applied to this pull request:

  • swing

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the swing client-libs-dev@openjdk.org label Jan 8, 2021
@mlbridge
Copy link

mlbridge bot commented Jan 8, 2021 •
edited

Webrevs

mrserb
mrserb reviewed Jan 9, 2021
View reviewed changes
test/jdk/javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java Outdated
@@ -61,7 +63,7 @@

public static void main(String[] args) throws Exception {
robot = new Robot();
robot.delay(2000);
robot.setAutoDelay(100);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you need an autodeley here? It seems the test does not use any of mouseXXX/keyXXX methods.

trebari
trebari reviewed Jan 11, 2021
View reviewed changes
test/jdk/javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java
@@ -208,6 +216,8 @@ private static void getIconBufferedImage() throws Exception {
private static void testIfSame(final String lookAndFeelString)
throws Exception {
if (!bufferedImagesEqual(imageIconImage, iconImage)) {
ImageIO.write(imageIconImage, "png", new File("imageicon-fail.png"));
ImageIO.write(iconImage, "png", new File("iconImage-fail.png"));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this for debugging purpose when the test fails ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

@openjdk
Copy link

openjdk bot commented Jan 11, 2021 •
edited

@prsadhuk This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8225045: javax/swing/JInternalFrame/8146321/JInternalFrameIconTest.java fails on linux-x64

Reviewed-by: serb, pbansal, trebari

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 92 new commits pushed to the master branch:

  • 77f6290: 8258254: Move PtrQueue flush to PtrQueueSet subclasses
  • 2255ab7: 8258810: Improve enum traits
  • ae0532e: 8259044: JVM lacks data type qualifier when using -XX:+PrintAssembly with AArch64-Neon backend
  • b378f54: Merge
  • 2cb271e: 8253996: Javac error on jdk16 build 18: invalid flag: -Xdoclint:-missing
  • d60a937: 8259028: ClassCastException when using custom filesystem with wrapper FileChannel impl
  • e05f36f: 8259043: More Zero architectures need linkage with libatomic
  • 020ec84: 8259429: Update reference to README.md
  • fb68395: 8259014: (so) ServerSocketChannel.bind(UnixDomainSocketAddress)/SocketChannel.bind(UnixDomainSocketAddress) will have unknown user and group owner (win)
  • b6d51e1: 8259585: Accessible actions do not work on mac os x
  • ... and 82 more: https://git.openjdk.java.net/jdk/compare/227f99d394571331ffa40b0b6b9d9d61c90635dd...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 11, 2021
@prsadhuk
Copy link
Contributor Author

/integrate

@openjdk openjdk bot closed this Jan 13, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 13, 2021
@openjdk
Copy link

openjdk bot commented Jan 13, 2021

@prsadhuk Since your change was applied there have been 113 commits pushed to the master branch:

  • 44c8379: 8256019: JLabel HTML text does not support translucent text colors
  • 0957d9e: 8259519: The java.awt.datatransfer.DataFlavor#ioInputStreamClass field is redundant
  • 65bed64: 8253635: Implement toString() for SSLEngineImpl
  • c6d798c: 8259629: aarch64 builds fail after JDK-8258932
  • 4be2173: 8259319: Illegal package access when SunPKCS11 requires SunJCE's classes
  • e4df209: 7018932: Drawing very large coordinates with a dashed Stroke can cause Java to hang
  • 5f7ccce: 8226810: Failed to launch JVM because of NullPointerException occured on System.props
  • d6a2105: 8259343: [macOS] Update JNI error handling in Cocoa code.
  • c338f11: 8259349: -XX:AvgMonitorsPerThreadEstimate=1 does not work right
  • ccac7aa: 8258932: AArch64: Enhance floating-point Min/MaxReductionV with fminp/fmaxp
  • ... and 103 more: https://git.openjdk.java.net/jdk/compare/227f99d394571331ffa40b0b6b9d9d61c90635dd...master

Your commit was automatically rebased without conflicts.

Pushed as commit a483869.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@prsadhuk prsadhuk deleted the JDK-8225045 branch January 13, 2021 07:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pankaj-bansal pankaj-bansal pankaj-bansal approved these changes

@mrserb mrserb mrserb approved these changes

@trebari trebari trebari approved these changes

Assignees
No one assigned
Labels
integrated Pull request has been integrated swing client-libs-dev@openjdk.org
Milestone
No milestone
4 participants
@prsadhuk @pankaj-bansal @mrserb @trebari