Skip to content

8207908: JMXStatusTest.java fails assertion intermittently #20037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

kevinjwalls
Copy link
Contributor

@kevinjwalls kevinjwalls commented Jul 4, 2024

Test failure, reproducible running batches of tests at the same time on the same machine.
The use of "jcmd TestApp ..." gathers more output than the test wants and than its regexes can handle.

Using the PID to match only the wanted process, my batches of 25 tests at the same time run in parallel without failure.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8207908: JMXStatusTest.java fails assertion intermittently (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20037/head:pull/20037
$ git checkout pull/20037

Update a local copy of the PR:
$ git checkout pull/20037
$ git pull https://git.openjdk.org/jdk.git pull/20037/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 20037

View PR using the GUI difftool:
$ git pr show -t 20037

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20037.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 4, 2024

👋 Welcome back kevinw! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 4, 2024

@kevinjwalls This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8207908: JMXStatusTest.java fails assertion intermittently

Reviewed-by: cjplummer, amenkov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 73 new commits pushed to the master branch:

  • 242f113: 8334481: [JVMCI] add LINK_TO_NATIVE to MethodHandleAccessProvider.IntrinsicMethod
  • 66db715: 8335637: Add explicit non-null return value expectations to Object.toString()
  • 7ab96c7: 8335409: Can't allocate and retain memory from resource area in frame::oops_interpreted_do oop closure after 8329665
  • fb66716: 8331725: ubsan: pc may not always be the entry point for a VtableStub
  • fb9a227: 8313909: [JVMCI] assert(cp->tag_at(index).is_unresolved_klass()) in lookupKlassInPool
  • e6c5aa7: 8336012: Fix usages of jtreg-reserved properties
  • e0fb949: 8335779: JFR: Hide sleep events
  • 537d20a: 8335766: Switch case with pattern matching and guard clause compiles inconsistently
  • a44b60c: 8335778: runtime/ClassInitErrors/TestStackOverflowDuringInit.java fails on ppc64 platforms after JDK-8334545
  • b5909ca: 8323242: Remove vestigial DONT_USE_REGISTER_DEFINES
  • ... and 63 more: https://git.openjdk.org/jdk/compare/6923a5114b2a9f02f0d6f0fefc21141ac3b9322a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented Jul 4, 2024

@kevinjwalls The following labels will be automatically applied to this pull request:

  • hotspot-runtime
  • jmx
  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added serviceability serviceability-dev@openjdk.org hotspot-runtime hotspot-runtime-dev@openjdk.org jmx jmx-dev@openjdk.org labels Jul 4, 2024
@kevinjwalls kevinjwalls marked this pull request as ready for review July 4, 2024 14:43
@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 4, 2024
@mlbridge
Copy link

mlbridge bot commented Jul 4, 2024

Webrevs

Copy link
Contributor

@plummercj plummercj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 10, 2024
@kevinjwalls
Copy link
Contributor Author

Thanks for the reviews!

@kevinjwalls
Copy link
Contributor Author

/integrate

@openjdk
Copy link

openjdk bot commented Jul 11, 2024

Going to push as commit b7d0eff.
Since your change was applied there have been 77 commits pushed to the master branch:

  • cf940e1: 8335553: [Graal] Compiler thread calls into jdk.internal.vm.VMSupport.decodeAndThrowThrowable and crashes in OOM situation
  • b363de8: 8335946: DTrace code snippets should be generated when DTrace flags are enabled
  • d6c6847: 8335743: jhsdb jstack cannot print some information on the waiting thread
  • cad68e0: 8335935: Chained builders not sending transformed models to next transforms
  • 242f113: 8334481: [JVMCI] add LINK_TO_NATIVE to MethodHandleAccessProvider.IntrinsicMethod
  • 66db715: 8335637: Add explicit non-null return value expectations to Object.toString()
  • 7ab96c7: 8335409: Can't allocate and retain memory from resource area in frame::oops_interpreted_do oop closure after 8329665
  • fb66716: 8331725: ubsan: pc may not always be the entry point for a VtableStub
  • fb9a227: 8313909: [JVMCI] assert(cp->tag_at(index).is_unresolved_klass()) in lookupKlassInPool
  • e6c5aa7: 8336012: Fix usages of jtreg-reserved properties
  • ... and 67 more: https://git.openjdk.org/jdk/compare/6923a5114b2a9f02f0d6f0fefc21141ac3b9322a...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 11, 2024
@openjdk openjdk bot closed this Jul 11, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 11, 2024
@openjdk
Copy link

openjdk bot commented Jul 11, 2024

@kevinjwalls Pushed as commit b7d0eff.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hotspot-runtime hotspot-runtime-dev@openjdk.org integrated Pull request has been integrated jmx jmx-dev@openjdk.org serviceability serviceability-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

3 participants