Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8335775: Remove extraneous 's' in comment of rawmonitor.cpp test file #20051

Closed
wants to merge 1 commit into from

Conversation

jerboaa
Copy link
Contributor

@jerboaa jerboaa commented Jul 5, 2024

Trivial comment only change in a test. Please review!

Thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8335775: Remove extraneous 's' in comment of rawmonitor.cpp test file (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20051/head:pull/20051
$ git checkout pull/20051

Update a local copy of the PR:
$ git checkout pull/20051
$ git pull https://git.openjdk.org/jdk.git pull/20051/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 20051

View PR using the GUI difftool:
$ git pr show -t 20051

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20051.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 5, 2024

👋 Welcome back sgehwolf! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 5, 2024

@jerboaa This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8335775: Remove extraneous 's' in comment of rawmonitor.cpp test file

Reviewed-by: gdams, stuefe

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 6 new commits pushed to the master branch:

  • c8acea8: 8335706: G1: Remove unused G1ConcurrentRefine::RemSetSamplingClosure::_cset
  • bdf470b: 8335742: Problemlist gc/g1/TestMixedGCLiveThreshold.java#25percent with virtual threads
  • 6409ec3: 8335711: G1: Remove unused bot_updates argument in G1AllocRegion constructor
  • 4ec1ae1: 8331385: G1: Prefix HeapRegion helper classes with G1
  • b9d8056: 8332124: Jcmd should recognise options that look like requests for help
  • cff9e24: 8335493: check_gc_overhead_limit should reset SoftRefPolicy::_should_clear_all_soft_refs

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 5, 2024
@openjdk
Copy link

openjdk bot commented Jul 5, 2024

@jerboaa The following label will be automatically applied to this pull request:

  • serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the serviceability serviceability-dev@openjdk.org label Jul 5, 2024
@mlbridge
Copy link

mlbridge bot commented Jul 5, 2024

Webrevs

Copy link
Member

@tstuefe tstuefe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good and trivial

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 5, 2024
@jerboaa
Copy link
Contributor Author

jerboaa commented Jul 5, 2024

Thanks for the review!

@jerboaa
Copy link
Contributor Author

jerboaa commented Jul 5, 2024

/integrate

@openjdk
Copy link

openjdk bot commented Jul 5, 2024

Going to push as commit ff49f67.
Since your change was applied there have been 7 commits pushed to the master branch:

  • 194425d: 8335645: j.u.Formatter#trailingZeros improved with String repeat
  • c8acea8: 8335706: G1: Remove unused G1ConcurrentRefine::RemSetSamplingClosure::_cset
  • bdf470b: 8335742: Problemlist gc/g1/TestMixedGCLiveThreshold.java#25percent with virtual threads
  • 6409ec3: 8335711: G1: Remove unused bot_updates argument in G1AllocRegion constructor
  • 4ec1ae1: 8331385: G1: Prefix HeapRegion helper classes with G1
  • b9d8056: 8332124: Jcmd should recognise options that look like requests for help
  • cff9e24: 8335493: check_gc_overhead_limit should reset SoftRefPolicy::_should_clear_all_soft_refs

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 5, 2024
@openjdk openjdk bot closed this Jul 5, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 5, 2024
@openjdk
Copy link

openjdk bot commented Jul 5, 2024

@jerboaa Pushed as commit ff49f67.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated serviceability serviceability-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

3 participants