Skip to content

8310915: Typo in aarch64.ad: "envcodings"#20081

Closed
brianjstafford wants to merge 1 commit intoopenjdk:masterfrom
brianjstafford:aarch64.ad-trivial-update
Closed

8310915: Typo in aarch64.ad: "envcodings"#20081
brianjstafford wants to merge 1 commit intoopenjdk:masterfrom
brianjstafford:aarch64.ad-trivial-update

Conversation

@brianjstafford
Copy link
Contributor

@brianjstafford brianjstafford commented Jul 8, 2024

This is a trivial update to a comment that starts with an unnecessary extra slash and contains a typo.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8310915: Typo in aarch64.ad: "envcodings" (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20081/head:pull/20081
$ git checkout pull/20081

Update a local copy of the PR:
$ git checkout pull/20081
$ git pull https://git.openjdk.org/jdk.git pull/20081/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 20081

View PR using the GUI difftool:
$ git pr show -t 20081

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20081.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 8, 2024

👋 Welcome back bstafford! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 8, 2024

@brianjstafford This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8310915: Typo in aarch64.ad: "envcodings"

Reviewed-by: thartmann

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 12 new commits pushed to the master branch:

  • 7e11fb7: 8335688: Fix -Wzero-as-null-pointer-constant warnings from fflush calls in jvmti tests
  • 531a6d8: 8335911: Document ccls indexer in doc/ide.md
  • 0e0dfca: 8330806: test/hotspot/jtreg/compiler/c1/TestLargeMonitorOffset.java fails on ARM32
  • f3ff4f7: 8335882: platform/cgroup/TestSystemSettings.java fails on Alpine Linux
  • 8f62f31: 8335906: [s390x] Test Failure: GTestWrapper.java
  • 2a29647: 8334777: Test javax/management/remote/mandatory/notif/NotifReconnectDeadlockTest.java failed with NullPointerException
  • 564a72e: 8335955: JDK-8335742 wrongly used a "JDK-" prefix in the problemlist bug number
  • 9c7a6ea: 8312125: Refactor CDS enum class handling
  • bb1f8a1: 8335904: Fix invalid comment in ShenandoahLock
  • babf6df: 8334757: AssertionError: Missing type variable in where clause
  • ... and 2 more: https://git.openjdk.org/jdk/compare/284671a1e4fb5bfe15b20b7f41fc24415b1235ed...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@TobiHartmann) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 8, 2024
@openjdk
Copy link

openjdk bot commented Jul 8, 2024

@brianjstafford The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Jul 8, 2024
@brianjstafford brianjstafford changed the title 8310915: Trivial update to comment in aarch64.ad 8310915: Typo in aarch64.ad: "envcodings" Jul 8, 2024
@mlbridge
Copy link

mlbridge bot commented Jul 8, 2024

Webrevs

Copy link
Member

@TobiHartmann TobiHartmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and trivial.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 9, 2024
@brianjstafford
Copy link
Contributor Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jul 9, 2024
@openjdk
Copy link

openjdk bot commented Jul 9, 2024

@brianjstafford
Your change (at version 9e08da8) is now ready to be sponsored by a Committer.

@jaikiran
Copy link
Member

Tobias has approved this trivial change and there has been no changes to the PR since that approval (which is a good thing). I'll go ahead and sponsor this.

@jaikiran
Copy link
Member

/sponsor

@openjdk
Copy link

openjdk bot commented Jul 13, 2024

Going to push as commit 6f325db.
Since your change was applied there have been 62 commits pushed to the master branch:

  • ae9f318: 8336301: test/jdk/java/nio/channels/AsyncCloseAndInterrupt.java leaves around a FIFO file upon test completion
  • 4166e53: 8318106: Generated HTML for snippet does not always contain an id
  • 5bc86f3: 8336259: Wrong link to stylesheet.css in JavaDoc API documentation
  • 8ba9bc6: 8332249: Micro-optimize Method.hashCode
  • 4957145: 8336278: Micro-optimize Replace String.format("%n") to System.lineSeparator
  • 1f6e106: 8335684: Test ThreadCpuTime.java should pause like ThreadCpuTimeArray.java
  • 84c74ad: 8335802: Improve startup speed HexFormat uses boolean instead of enum
  • 4f312d6: 8336152: Remove unused forward declaration in classLoadInfo.hpp
  • 34d8562: 8335902: Parallel: Refactor VM_ParallelGCFailedAllocation and VM_ParallelGCSystemGC
  • 2fc7eb4: 8155030: The Menu Mnemonics are always displayed for GTK LAF
  • ... and 52 more: https://git.openjdk.org/jdk/compare/284671a1e4fb5bfe15b20b7f41fc24415b1235ed...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 13, 2024
@openjdk openjdk bot closed this Jul 13, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jul 13, 2024
@openjdk
Copy link

openjdk bot commented Jul 13, 2024

@jaikiran @brianjstafford Pushed as commit 6f325db.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

3 participants