8335553: [Graal] Compiler thread calls into jdk.internal.vm.VMSupport.decodeAndThrowThrowable and crashes in OOM situation #20083

dougxc · 2024-07-08T19:01:05Z

This PR addresses intermittent failures in jtreg GC stress tests. The failures occur under these conditions:

Using a libgraal build with assertions enabled as the top tier JIT compiler. Such a libgraal build will cause a VM exit if an assertion or GraalError occurs in a compiler thread (as this catches more errors in testing).
A libgraal compiler thread makes a call into the VM (via CompilerToVM) to a routine that performs a HotSpot heap allocation that fails.
The resulting OOME is wrapped in a GraalError, causing the VM to exit as described in 1.

An OOME thrown in these specific conditions should not exit the VM as it not related to an OOME in the app or test. Instead, the failure should be treated as a bailout and the libgraal compiler should continue.

To accomplish this, libgraal needs to be able to distinguish a GraalError caused by an OOME. This PR modifies the exception translation code to make this possible.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8335553: [Graal] Compiler thread calls into jdk.internal.vm.VMSupport.decodeAndThrowThrowable and crashes in OOM situation (Bug - P4)

Reviewers

Yudi Zheng (@mur47x111 - Committer)
Tom Rodriguez (@tkrodriguez - Reviewer)
David Holmes (@dholmes-ora - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20083/head:pull/20083
$ git checkout pull/20083

Update a local copy of the PR:
$ git checkout pull/20083
$ git pull https://git.openjdk.org/jdk.git pull/20083/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 20083

View PR using the GUI difftool:
$ git pr show -t 20083

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20083.diff

Webrev

Link to Webrev Comment

bridgekeeper · 2024-07-08T19:01:55Z

👋 Welcome back dnsimon! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2024-07-08T19:02:34Z

@dougxc This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8335553: [Graal] Compiler thread calls into jdk.internal.vm.VMSupport.decodeAndThrowThrowable and crashes in OOM situation

Reviewed-by: yzheng, never, dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 35 new commits pushed to the master branch:

cad68e0: 8335935: Chained builders not sending transformed models to next transforms
242f113: 8334481: [JVMCI] add LINK_TO_NATIVE to MethodHandleAccessProvider.IntrinsicMethod
66db715: 8335637: Add explicit non-null return value expectations to Object.toString()
7ab96c7: 8335409: Can't allocate and retain memory from resource area in frame::oops_interpreted_do oop closure after 8329665
fb66716: 8331725: ubsan: pc may not always be the entry point for a VtableStub
fb9a227: 8313909: [JVMCI] assert(cp->tag_at(index).is_unresolved_klass()) in lookupKlassInPool
e6c5aa7: 8336012: Fix usages of jtreg-reserved properties
e0fb949: 8335779: JFR: Hide sleep events
537d20a: 8335766: Switch case with pattern matching and guard clause compiles inconsistently
a44b60c: 8335778: runtime/ClassInitErrors/TestStackOverflowDuringInit.java fails on ppc64 platforms after JDK-8334545
... and 25 more: https://git.openjdk.org/jdk/compare/55fd1ed228ea3c42aaf92579e5dcb818fe14351d...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk · 2024-07-08T19:02:56Z

@dougxc The following labels will be automatically applied to this pull request:

core-libs
graal
hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

src/hotspot/share/utilities/exceptions.cpp

dougxc · 2024-07-08T19:12:33Z

src/hotspot/share/utilities/exceptions.cpp

 #endif // ASSERT

-  if (!thread->can_call_java()) {
+  if (h_exception.is_null() && !thread->can_call_java()) {


There is no reason to replace an existing exception object with a dummy exception object in the case where the current thread cannot call into Java. Since the exception object already exists, no Java call is necessary.

This change is necessary to allow the libgraal exception translation mechanism to know that an OOME is being translated.

mlbridge · 2024-07-09T07:52:58Z

Webrevs

01: Full - Incremental (aa32491c)
00: Full (ff544be3)

mur47x111 · 2024-07-09T14:13:58Z

test/jdk/jdk/internal/vm/TestTranslatedException.java

-    private static void assertThrowableEquals(Throwable original, Throwable decoded) {
+    private static void assertThrowableEquals(Throwable originalIn, Throwable decodedIn) {
+        Throwable original = originalIn;
+        Throwable decoded = decodedIn;


What is the purpose of this renaming?

So that the printing down the bottom of this message shows the complete throwable, not just the cause on which the comparison failed.

Thanks! I missed the reassign in the folded unchanged code.

mur47x111 · 2024-07-09T14:37:47Z

src/hotspot/share/jvmci/jvmciCompilerToVM.cpp

+      Handle garbage;
+      while (true) {
+        // Trigger an OutOfMemoryError
+        objArrayOop next = oopFactory::new_objectArray(0x7FFFFFFF, CHECK_NULL);


Shall we check for pending exception and break here?

The CHECK_NULL macro effectively does that.

mur47x111

LGTM

tkrodriguez

looks good.

dholmes-ora

Non JVMCI changes look good. Thanks

dougxc · 2024-07-11T07:02:54Z

Thanks for the reviews.

/integrate

openjdk · 2024-07-11T07:03:46Z

Going to push as commit cf940e1.
Since your change was applied there have been 37 commits pushed to the master branch:

b363de8: 8335946: DTrace code snippets should be generated when DTrace flags are enabled
d6c6847: 8335743: jhsdb jstack cannot print some information on the waiting thread
cad68e0: 8335935: Chained builders not sending transformed models to next transforms
242f113: 8334481: [JVMCI] add LINK_TO_NATIVE to MethodHandleAccessProvider.IntrinsicMethod
66db715: 8335637: Add explicit non-null return value expectations to Object.toString()
7ab96c7: 8335409: Can't allocate and retain memory from resource area in frame::oops_interpreted_do oop closure after 8329665
fb66716: 8331725: ubsan: pc may not always be the entry point for a VtableStub
fb9a227: 8313909: [JVMCI] assert(cp->tag_at(index).is_unresolved_klass()) in lookupKlassInPool
e6c5aa7: 8336012: Fix usages of jtreg-reserved properties
e0fb949: 8335779: JFR: Hide sleep events
... and 27 more: https://git.openjdk.org/jdk/compare/55fd1ed228ea3c42aaf92579e5dcb818fe14351d...master

Your commit was automatically rebased without conflicts.

openjdk · 2024-07-11T07:03:54Z

@dougxc Pushed as commit cf940e1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

openjdk bot added graal graal-dev@openjdk.org hotspot hotspot-dev@openjdk.org core-libs core-libs-dev@openjdk.org labels Jul 8, 2024

dougxc commented Jul 8, 2024

View reviewed changes

src/hotspot/share/utilities/exceptions.cpp Show resolved Hide resolved

dougxc commented Jul 8, 2024

View reviewed changes

dougxc force-pushed the JDK-8335553 branch 2 times, most recently from b53dfce to 27cd743 Compare July 9, 2024 07:39

improved exception translation between HotSpot and libgraal heaps

ff544be

dougxc force-pushed the JDK-8335553 branch from 27cd743 to ff544be Compare July 9, 2024 07:46

dougxc marked this pull request as ready for review July 9, 2024 07:47

openjdk bot added the rfr Pull request is ready for review label Jul 9, 2024

fixed TestTranslatedException

aa32491

mur47x111 reviewed Jul 9, 2024

View reviewed changes

mur47x111 approved these changes Jul 9, 2024

View reviewed changes

tkrodriguez approved these changes Jul 10, 2024

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Jul 10, 2024

dholmes-ora approved these changes Jul 11, 2024

View reviewed changes

openjdk bot added the integrated Pull request has been integrated label Jul 11, 2024

openjdk bot closed this Jul 11, 2024

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 11, 2024

zapster mentioned this pull request Jul 23, 2024

[GR-55585] Update labsjdk to 24+7-jvmci-b01 oracle/graal#9333

Merged

8335553: [Graal] Compiler thread calls into jdk.internal.vm.VMSupport.decodeAndThrowThrowable and crashes in OOM situation #20083

8335553: [Graal] Compiler thread calls into jdk.internal.vm.VMSupport.decodeAndThrowThrowable and crashes in OOM situation #20083

Uh oh!

Conversation

dougxc commented Jul 8, 2024 • edited by openjdk bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Progress

Issue

Reviewers

Reviewing

Webrev

Uh oh!

bridgekeeper bot commented Jul 8, 2024

Uh oh!

openjdk bot commented Jul 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

openjdk bot commented Jul 8, 2024

Uh oh!

Uh oh!

dougxc Jul 8, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mlbridge bot commented Jul 9, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Webrevs

Uh oh!

mur47x111 Jul 9, 2024

Choose a reason for hiding this comment

Uh oh!

dougxc Jul 9, 2024

Choose a reason for hiding this comment

Uh oh!

mur47x111 Jul 9, 2024

Choose a reason for hiding this comment

Uh oh!

mur47x111 Jul 9, 2024

Choose a reason for hiding this comment

Uh oh!

dougxc Jul 9, 2024

Choose a reason for hiding this comment

Uh oh!

mur47x111 left a comment

Choose a reason for hiding this comment

Uh oh!

tkrodriguez left a comment

Choose a reason for hiding this comment

Uh oh!

dholmes-ora left a comment

Choose a reason for hiding this comment

Uh oh!

dougxc commented Jul 11, 2024

Uh oh!

openjdk bot commented Jul 11, 2024

Uh oh!

openjdk bot commented Jul 11, 2024

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

4 participants

dougxc commented Jul 8, 2024 •

edited by openjdk bot

Loading

openjdk bot commented Jul 8, 2024 •

edited

Loading

dougxc Jul 8, 2024 •

edited

Loading

mlbridge bot commented Jul 9, 2024 •

edited

Loading