8334757: AssertionError: Missing type variable in where clause

[cushon]

Please review this clean backport of #19840 to JDK 23, which avoids a crash when types with type variables appear as arguments for diagnostics that use JCDiagnostic.AnnotatedType.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8334757: AssertionError: Missing type variable in where clause (Bug - P2)

Reviewers

• Jan Lahoda (@lahodaj - Reviewer)
• Vicente Romero (@vicente-romero-oracle - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20085/head:pull/20085
$ git checkout pull/20085

Update a local copy of the PR:
$ git checkout pull/20085
$ git pull https://git.openjdk.org/jdk.git pull/20085/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 20085

View PR using the GUI difftool:
$ git pr show -t 20085

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20085.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back cushon! A progress list of the required criteria for merging this PR into jdk23 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@cushon This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8334757: AssertionError: Missing type variable in where clause

Reviewed-by: jlahoda, vromero

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 2 new commits pushed to the jdk23 branch:

• ae10055: 8335824: Test gc/arguments/TestMinInitialErgonomics.java is timing out
• 4e52320: 8334433: jshell.exe runs an executable test.exe on startup

Please see this link for an up-to-date comparison between the source branch of this pull request and the jdk23 branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the jdk23 branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

@cushon The following label will be automatically applied to this pull request:

• compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (3337e5fb)

[lahodaj]

Looks good to me.

[vicente-romero-oracle]

looks good

[cushon]

/integrate

[openjdk]

Going to push as commit ca37a48.
Since your change was applied there have been 2 commits pushed to the jdk23 branch:

• ae10055: 8335824: Test gc/arguments/TestMinInitialErgonomics.java is timing out
• 4e52320: 8334433: jshell.exe runs an executable test.exe on startup

Your commit was automatically rebased without conflicts.

[openjdk]

@cushon Pushed as commit ca37a48.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.