Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8259493: [test] Use HexFormat instead of adhoc hex utilities in network code and locale SoftKeys #2009

Closed
wants to merge 1 commit into from

Conversation

@RogerRiggs
Copy link
Contributor

@RogerRiggs RogerRiggs commented Jan 8, 2021

Cleanup of tests test/jdk/java/net and test/jdk/sun/net that format hexadecimal strings to use java.util.HexFormat methods.
Also in tests test/jdk/java/util/Locale/SoftKeys.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8259493: [test] Use HexFormat instead of adhoc hex utilities in network code and locale SoftKeys

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2009/head:pull/2009
$ git checkout pull/2009

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jan 8, 2021

👋 Welcome back rriggs! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jan 8, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 8, 2021

@RogerRiggs The following labels will be automatically applied to this pull request:

  • core-libs
  • i18n
  • net

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jan 8, 2021

Webrevs

Copy link
Contributor

@LanceAndersen LanceAndersen left a comment

Looks good Roger. Nice cleanup.

@openjdk
Copy link

@openjdk openjdk bot commented Jan 8, 2021

@RogerRiggs This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8259493: [test] Use HexFormat instead of adhoc hex utilities in network code and locale SoftKeys

Reviewed-by: lancea, naoto

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jan 8, 2021
naotoj
naotoj approved these changes Jan 8, 2021
Copy link
Member

@naotoj naotoj left a comment

+1

@RogerRiggs
Copy link
Contributor Author

@RogerRiggs RogerRiggs commented Jan 8, 2021

/integrate

@openjdk openjdk bot closed this Jan 8, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jan 8, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 8, 2021

@RogerRiggs Pushed as commit 876c7fb.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@RogerRiggs RogerRiggs deleted the 8259493-net-hexformat branch Jan 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants