Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8253222: Shenandoah: unused AlwaysTrueClosure after JDK-8246591 #201

Closed

Conversation

@shipilev
Copy link
Contributor

@shipilev shipilev commented Sep 16, 2020

Static analysis shows the AlwaysTrueClosure is not needed in ShenandoahRootScanner::roots_do after JDK-8246591.

Testing: Linux x86_64 tier1_gc_shenandoah


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8253222: Shenandoah: unused AlwaysTrueClosure after JDK-8246591

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/201/head:pull/201
$ git checkout pull/201

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Sep 16, 2020

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Sep 16, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 16, 2020

@shipilev The following labels will be automatically applied to this pull request: hotspot-gc shenandoah.

When this pull request is ready to be reviewed, an RFR email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label (add|remove) "label" command.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Sep 16, 2020

Webrevs

Copy link
Contributor

@rkennke rkennke left a comment

Looks good. Thank you!

@openjdk
Copy link

@openjdk openjdk bot commented Sep 16, 2020

@shipilev This change now passes all automated pre-integration checks. In addition to the automated checks, the change must also fulfill all project specific requirements

After integration, the commit message will be:

8253222: Shenandoah: unused AlwaysTrueClosure after JDK-8246591

Reviewed-by: rkennke
  • If you would like to add a summary, use the /summary command.
  • To credit additional contributors, use the /contributor command.
  • To add additional solved issues, use the /issue command.

There are currently no new commits on the master branch since the last update of the source branch of this PR. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you would like to avoid potential automatic rebasing, specify the current head hash when integrating, like this: /integrate efe3540d8f3156b337133ad12272834f6ded2203.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Sep 16, 2020
@shipilev
Copy link
Contributor Author

@shipilev shipilev commented Sep 16, 2020

/integrate

@openjdk openjdk bot closed this Sep 16, 2020
@openjdk openjdk bot added integrated and removed ready rfr labels Sep 16, 2020
@openjdk
Copy link

@openjdk openjdk bot commented Sep 16, 2020

@shipilev Pushed as commit dd43533.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@shipilev shipilev deleted the JDK-8253222-shenandoah-alwaystrue branch Sep 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants