8335905: CompoundElement API cleanup

[liach]

CompoundElement already inherits Iterable and its forEach(Consumer), thus we can remove Iterable elements() and forEachElements(Consumer).

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change requires CSR request JDK-8336034 to be approved
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issues

• JDK-8335905: CompoundElement API cleanup (Enhancement - P4)
• JDK-8336034: CompoundElement API cleanup (CSR)

Reviewers

• Adam Sotona (@asotona - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20103/head:pull/20103
$ git checkout pull/20103

Update a local copy of the PR:
$ git checkout pull/20103
$ git pull https://git.openjdk.org/jdk.git pull/20103/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 20103

View PR using the GUI difftool:
$ git pr show -t 20103

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20103.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back liach! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@liach This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8335905: CompoundElement API cleanup

Reviewed-by: asotona

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 51 new commits pushed to the master branch:

• 6f325db: 8310915: Typo in aarch64.ad: "envcodings"
• ae9f318: 8336301: test/jdk/java/nio/channels/AsyncCloseAndInterrupt.java leaves around a FIFO file upon test completion
• 4166e53: 8318106: Generated HTML for snippet does not always contain an id
• 5bc86f3: 8336259: Wrong link to stylesheet.css in JavaDoc API documentation
• 8ba9bc6: 8332249: Micro-optimize Method.hashCode
• 4957145: 8336278: Micro-optimize Replace String.format("%n") to System.lineSeparator
• 1f6e106: 8335684: Test ThreadCpuTime.java should pause like ThreadCpuTimeArray.java
• 84c74ad: 8335802: Improve startup speed HexFormat uses boolean instead of enum
• 4f312d6: 8336152: Remove unused forward declaration in classLoadInfo.hpp
• 34d8562: 8335902: Parallel: Refactor VM_ParallelGCFailedAllocation and VM_ParallelGCSystemGC
• ... and 41 more: https://git.openjdk.org/jdk/compare/7e11fb702696df733ca89d325200f2e9414402d9...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@liach The following labels will be automatically applied to this pull request:

• compiler
• core-libs
• hotspot-jfr

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (9caa520d)
• 00: Full (ea069e81)

[liach]

/label remove compiler,hotspot-jfr

[openjdk]

@liach
The compiler label was successfully removed.

The hotspot-jfr label was successfully removed.

[asotona]

Nice cleanup.

[liach]

/integrate

Thanks for the reviews!

[openjdk]

Going to push as commit a9f5e76.
Since your change was applied there have been 51 commits pushed to the master branch:

• 6f325db: 8310915: Typo in aarch64.ad: "envcodings"
• ae9f318: 8336301: test/jdk/java/nio/channels/AsyncCloseAndInterrupt.java leaves around a FIFO file upon test completion
• 4166e53: 8318106: Generated HTML for snippet does not always contain an id
• 5bc86f3: 8336259: Wrong link to stylesheet.css in JavaDoc API documentation
• 8ba9bc6: 8332249: Micro-optimize Method.hashCode
• 4957145: 8336278: Micro-optimize Replace String.format("%n") to System.lineSeparator
• 1f6e106: 8335684: Test ThreadCpuTime.java should pause like ThreadCpuTimeArray.java
• 84c74ad: 8335802: Improve startup speed HexFormat uses boolean instead of enum
• 4f312d6: 8336152: Remove unused forward declaration in classLoadInfo.hpp
• 34d8562: 8335902: Parallel: Refactor VM_ParallelGCFailedAllocation and VM_ParallelGCSystemGC
• ... and 41 more: https://git.openjdk.org/jdk/compare/7e11fb702696df733ca89d325200f2e9414402d9...master

Your commit was automatically rebased without conflicts.

[openjdk]

@liach Pushed as commit a9f5e76.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.