8313909: [JVMCI] assert(cp->tag_at(index).is_unresolved_klass()) in lookupKlassInPool

[dougxc]

This PR converts a very rare assertion failure into an exception throw that will a) be more informative about the unexpected value in debug build and b) bailout of a compilation in product builds.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8313909: [JVMCI] assert(cp->tag_at(index).is_unresolved_klass()) in lookupKlassInPool (Bug - P3)

Reviewers

• Yudi Zheng (@mur47x111 - Committer)
• Tom Rodriguez (@tkrodriguez - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20105/head:pull/20105
$ git checkout pull/20105

Update a local copy of the PR:
$ git checkout pull/20105
$ git pull https://git.openjdk.org/jdk.git pull/20105/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 20105

View PR using the GUI difftool:
$ git pr show -t 20105

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20105.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back dnsimon! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@dougxc This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8313909: [JVMCI] assert(cp->tag_at(index).is_unresolved_klass()) in lookupKlassInPool

Reviewed-by: yzheng, never

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

• e6c5aa7: 8336012: Fix usages of jtreg-reserved properties
• e0fb949: 8335779: JFR: Hide sleep events
• 537d20a: 8335766: Switch case with pattern matching and guard clause compiles inconsistently
• a44b60c: 8335778: runtime/ClassInitErrors/TestStackOverflowDuringInit.java fails on ppc64 platforms after JDK-8334545

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@dougxc The following labels will be automatically applied to this pull request:

• graal
• hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (8a0ae873)

[tkrodriguez]

It was probably a race caused by the refetch of the tag by the assert so I think this might also turn out to be a fix.

[dougxc]

Thanks for the reviews.

/integrate

[openjdk]

Going to push as commit fb9a227.
Since your change was applied there have been 4 commits pushed to the master branch:

• e6c5aa7: 8336012: Fix usages of jtreg-reserved properties
• e0fb949: 8335779: JFR: Hide sleep events
• 537d20a: 8335766: Switch case with pattern matching and guard clause compiles inconsistently
• a44b60c: 8335778: runtime/ClassInitErrors/TestStackOverflowDuringInit.java fails on ppc64 platforms after JDK-8334545

Your commit was automatically rebased without conflicts.

[openjdk]

@dougxc Pushed as commit fb9a227.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.