8335533: OutOfMemoryError: Metaspace observed again on AIX in test RedefineLeakThrowable.java after JDK-8294960

[RealCLanger]

The change of JDK-8294960 has brought an increase of required metaspace for this test on AIX which seems to go beyond 23m in most cases. So I propose another slight increment.

Why AIX needs more metaspace compared to other platforms is probably a different topic.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8335533: OutOfMemoryError: Metaspace observed again on AIX in test RedefineLeakThrowable.java after JDK-8294960 (Bug - P4)

Reviewers

• Matthias Baesken (@MBaesken - Reviewer)
• Thomas Stuefe (@tstuefe - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20106/head:pull/20106
$ git checkout pull/20106

Update a local copy of the PR:
$ git checkout pull/20106
$ git pull https://git.openjdk.org/jdk.git pull/20106/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 20106

View PR using the GUI difftool:
$ git pr show -t 20106

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20106.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back clanger! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@RealCLanger This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8335533: OutOfMemoryError: Metaspace observed again on AIX in test RedefineLeakThrowable.java after JDK-8294960

Reviewed-by: mbaesken, stuefe

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

• 537d20a: 8335766: Switch case with pattern matching and guard clause compiles inconsistently

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@RealCLanger The following label will be automatically applied to this pull request:

• serviceability

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (4d33c99f)

[MBaesken]

LGTM ; I observed a very small increase on Linux x86_64 too but not enough to 'break' the metaspace test settings on this platform.

[tstuefe]

There is nothing I know off-hand that would be AIX-specific. Or is it PPC-specific? If the latter, does the delta go away with -Xint, or if you only run with C1?

Other than that, to analyze the problem, I would stop the test on a defined point on both a good platform and AIX, and do:

jcmd <pid> VM.metaspace show-loaders show-classes and maybe also start the tests with -Xlog:metaspace=trace

and attach the results to the JBS issue.

[tstuefe]

+1

[tstuefe]

There is nothing I know off-hand that would be AIX-specific. Or is it PPC-specific? If the latter, does the delta go away with -Xint, or if you only run with C1?

Other than that, to analyze the problem, I would stop the test on a defined point on both a good platform and AIX, and do:

jcmd <pid> VM.metaspace show-loaders show-classes and maybe also start the tests with -Xlog:metaspace=trace

and attach the results to the JBS issue.

resp. open a new issue, if this issue is just about increasing the metaspace limit

[RealCLanger]

/integrate

[openjdk]

Going to push as commit 419cc46.
Since your change was applied there have been 60 commits pushed to the master branch:

• 8feabc8: 8334057: JLinkReproducibleTest.java support receive test.tool.vm.opts
• bc7cd42: 8314498: [macos] Transferring File objects to Finder fails
• c8a95a7: 8072701: resume001 failed due to ERROR: timeout for waiting for a BreakpintEvent
• 388fcf0: 8336349: Fix more simple -Wzero-as-null-pointer-constant warnings in C2 code
• ab27aca: 8336297: C2: Fix -Wzero-as-null-pointer-constant warnings in derived Node ctors
• 9dfcd75: 8334121: Anonymous class capturing two enclosing instances fails to compile
• 000de30: 8335269: [Graal] occasional timeout in java/lang/StringBuffer/TestSynchronization.java with loom
• 4635531: 8335159: Move method reference to lambda desugaring before Lower
• a253e0f: 8335642: Hide Transform implementation for Class-File API
• 2b0adfc: 8335817: javac AssertionError addLocalVar checkNull
• ... and 50 more: https://git.openjdk.org/jdk/compare/a44b60c8c14ad998e51239f48e64779304aaac50...master

Your commit was automatically rebased without conflicts.

[openjdk]

@RealCLanger Pushed as commit 419cc46.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.