Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8333886: Explicitly specify that asSlice and reinterpret return a memory segment backed by the same region of memory. #20116

Conversation

JornVernee
Copy link
Member

@JornVernee JornVernee commented Jul 10, 2024

Hi all,

This pull request contains a backport of commit c80e2eb3 from the openjdk/jdk repository.

The commit being backported was authored by Per Minborg on 12 Jun 2024 and was reviewed by Jorn Vernee and Maurizio Cimadamore.

This is a P4 doc-only change, which is permitted in RDP1: https://openjdk.org/jeps/3#Quick-reference

This change should also make it possible to cleanly backport: 6f7f0f1

Thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Warning

 ⚠️ Found trailing period in issue title for 8333886: Explicitly specify that asSlice and reinterpret return a memory segment backed by the same region of memory.

Issue

  • JDK-8333886: Explicitly specify that asSlice and reinterpret return a memory segment backed by the same region of memory. (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20116/head:pull/20116
$ git checkout pull/20116

Update a local copy of the PR:
$ git checkout pull/20116
$ git pull https://git.openjdk.org/jdk.git pull/20116/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 20116

View PR using the GUI difftool:
$ git pr show -t 20116

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20116.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 10, 2024

👋 Welcome back jvernee! A progress list of the required criteria for merging this PR into jdk23 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 10, 2024

@JornVernee This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8333886: Explicitly specify that asSlice and reinterpret return a memory segment backed by the same region of memory.

Reviewed-by: sundar

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the jdk23 branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the jdk23 branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport c80e2eb35c4eb03f17a2a31e979e5c369453e203 8333886: Explicitly specify that asSlice and reinterpret return a memory segment backed by the same region of memory. Jul 10, 2024
@openjdk
Copy link

openjdk bot commented Jul 10, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk
Copy link

openjdk bot commented Jul 10, 2024

@JornVernee The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Jul 10, 2024
@JornVernee JornVernee marked this pull request as ready for review July 10, 2024 16:17
@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 10, 2024
Copy link
Member

@sundararajana sundararajana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 10, 2024
@JornVernee
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jul 10, 2024

Going to push as commit 5b9ecb1.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 10, 2024
@openjdk openjdk bot closed this Jul 10, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 10, 2024
@openjdk
Copy link

openjdk bot commented Jul 10, 2024

@JornVernee Pushed as commit 5b9ecb1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mlbridge
Copy link

mlbridge bot commented Jul 10, 2024

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants