Skip to content

Comments

8334481: [JVMCI] add LINK_TO_NATIVE to MethodHandleAccessProvider.IntrinsicMethod#20118

Closed
mur47x111 wants to merge 1 commit intoopenjdk:masterfrom
mur47x111:JDK-8334481
Closed

8334481: [JVMCI] add LINK_TO_NATIVE to MethodHandleAccessProvider.IntrinsicMethod#20118
mur47x111 wants to merge 1 commit intoopenjdk:masterfrom
mur47x111:JDK-8334481

Conversation

@mur47x111
Copy link
Contributor

@mur47x111 mur47x111 commented Jul 10, 2024

This PR allows Graal to query if a method is a vmIntrinsics::_linkToNative intrinsic.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8334481: [JVMCI] add LINK_TO_NATIVE to MethodHandleAccessProvider.IntrinsicMethod (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20118/head:pull/20118
$ git checkout pull/20118

Update a local copy of the PR:
$ git checkout pull/20118
$ git pull https://git.openjdk.org/jdk.git pull/20118/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 20118

View PR using the GUI difftool:
$ git pr show -t 20118

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20118.diff

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 10, 2024

👋 Welcome back yzheng! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 10, 2024

@mur47x111 This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8334481: [JVMCI] add LINK_TO_NATIVE to MethodHandleAccessProvider.IntrinsicMethod

Reviewed-by: dnsimon

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • 66db715: 8335637: Add explicit non-null return value expectations to Object.toString()
  • 7ab96c7: 8335409: Can't allocate and retain memory from resource area in frame::oops_interpreted_do oop closure after 8329665
  • fb66716: 8331725: ubsan: pc may not always be the entry point for a VtableStub
  • fb9a227: 8313909: [JVMCI] assert(cp->tag_at(index).is_unresolved_klass()) in lookupKlassInPool

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 10, 2024
@openjdk
Copy link

openjdk bot commented Jul 10, 2024

@mur47x111 The following labels will be automatically applied to this pull request:

  • graal
  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added graal graal-dev@openjdk.org hotspot-compiler hotspot-compiler-dev@openjdk.org labels Jul 10, 2024
@dougxc
Copy link
Member

dougxc commented Jul 10, 2024

LGTM.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 10, 2024
@mur47x111
Copy link
Contributor Author

Thanks for the review! Rerun of the pre-submit tests succeeded.

/integrate

@openjdk
Copy link

openjdk bot commented Jul 10, 2024

Going to push as commit 242f113.
Since your change was applied there have been 4 commits pushed to the master branch:

  • 66db715: 8335637: Add explicit non-null return value expectations to Object.toString()
  • 7ab96c7: 8335409: Can't allocate and retain memory from resource area in frame::oops_interpreted_do oop closure after 8329665
  • fb66716: 8331725: ubsan: pc may not always be the entry point for a VtableStub
  • fb9a227: 8313909: [JVMCI] assert(cp->tag_at(index).is_unresolved_klass()) in lookupKlassInPool

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 10, 2024
@openjdk openjdk bot closed this Jul 10, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 10, 2024
@openjdk
Copy link

openjdk bot commented Jul 10, 2024

@mur47x111 Pushed as commit 242f113.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@mlbridge
Copy link

mlbridge bot commented Jul 10, 2024

Webrevs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

graal graal-dev@openjdk.org hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants