8333884: MemorySegment::reinterpret removes read-only property

[JornVernee]

Hi all,

This pull request contains a backport of commit 6f7f0f1d from the openjdk/jdk repository.

The commit being backported was authored by Per Minborg on 6 Jul 2024 and was reviewed by Jorn Vernee and Maurizio Cimadamore.

Thanks!

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change requires CSR request JDK-8333892 to be approved
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issues

• JDK-8333884: MemorySegment::reinterpret removes read-only property (Bug - P3)
• JDK-8333892: MemorySegment::reinterpret removes read-only property (CSR)

Reviewers

• Chen Liang (@liach - Committer)
• Athijegannathan Sundararajan (@sundararajana - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20119/head:pull/20119
$ git checkout pull/20119

Update a local copy of the PR:
$ git checkout pull/20119
$ git pull https://git.openjdk.org/jdk.git pull/20119/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 20119

View PR using the GUI difftool:
$ git pr show -t 20119

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20119.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back jvernee! A progress list of the required criteria for merging this PR into jdk23 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@JornVernee This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8333884: MemorySegment::reinterpret removes read-only property

Reviewed-by: liach, sundar

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the jdk23 branch:

• 4aab58b: 8335637: Add explicit non-null return value expectations to Object.toString()

Please see this link for an up-to-date comparison between the source branch of this pull request and the jdk23 branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the jdk23 branch, type /integrate in a new comment.

[openjdk]

This backport pull request has now been updated with issue from the original commit.

[openjdk]

@JornVernee The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (aa553ef8)

[sundararajana]

LGTM

[JornVernee]

/integrate

[openjdk]

Going to push as commit 9620b91.
Since your change was applied there have been 3 commits pushed to the jdk23 branch:

• e991c0f: 8335766: Switch case with pattern matching and guard clause compiles inconsistently
• 6720685: 8335966: Remove incorrect problem listing of java/lang/instrument/NativeMethodPrefixAgent.java in ProblemList-Virtual.txt
• 4aab58b: 8335637: Add explicit non-null return value expectations to Object.toString()

Your commit was automatically rebased without conflicts.

[openjdk]

@JornVernee Pushed as commit 9620b91.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.