-
Notifications
You must be signed in to change notification settings - Fork 5.8k
8334653: ISO 4217 Amendment 177 Update #20126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8334653: ISO 4217 Amendment 177 Update #20126
Conversation
👋 Welcome back jlu! A progress list of the required criteria for merging this PR into |
@justin-curtis-lu This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 5 new commits pushed to the
Please see this link for an up-to-date comparison between the source branch of this pull request and the ➡️ To integrate this PR with the above commit message to the |
This backport pull request has now been updated with issue from the original commit. |
@justin-curtis-lu The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
Hi @Kboxoxx, thanks for making a comment in an OpenJDK project! All comments and discussions in the OpenJDK Community must be made available under the OpenJDK Terms of Use. If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please Use "Add GitHub user Kboxoxx" for the summary. If you are not an OpenJDK Author, Committer or Reviewer, simply check the box below to accept the OpenJDK Terms of Use for your comments.
Your comment will be automatically restored once you have accepted the OpenJDK Terms of Use. |
This message is kind of confusing. This PR is for |
@turbanoff true, I adjusted the message to indicate the original commit is from mainline. |
/integrate |
Going to push as commit 5162e1a.
Your commit was automatically rebased without conflicts. |
@justin-curtis-lu Pushed as commit 5162e1a. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
Please review this PR, which is a backport of commit 86b0cf25 from the openjdk/jdk mainline branch.
This change incorporates the ISO 4217 Amendment 177 Update.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20126/head:pull/20126
$ git checkout pull/20126
Update a local copy of the PR:
$ git checkout pull/20126
$ git pull https://git.openjdk.org/jdk.git pull/20126/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 20126
View PR using the GUI difftool:
$ git pr show -t 20126
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20126.diff
Webrev
Link to Webrev Comment