Skip to content

8334653: ISO 4217 Amendment 177 Update #20126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

justin-curtis-lu
Copy link
Member

@justin-curtis-lu justin-curtis-lu commented Jul 10, 2024

Please review this PR, which is a backport of commit 86b0cf25 from the openjdk/jdk mainline branch.

This change incorporates the ISO 4217 Amendment 177 Update.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8334653: ISO 4217 Amendment 177 Update (Bug - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20126/head:pull/20126
$ git checkout pull/20126

Update a local copy of the PR:
$ git checkout pull/20126
$ git pull https://git.openjdk.org/jdk.git pull/20126/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 20126

View PR using the GUI difftool:
$ git pr show -t 20126

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20126.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 10, 2024

👋 Welcome back jlu! A progress list of the required criteria for merging this PR into jdk23 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 10, 2024

@justin-curtis-lu This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8334653: ISO 4217 Amendment 177 Update

Reviewed-by: naoto, iris

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the jdk23 branch:

  • 06191ac: 8335935: Chained builders not sending transformed models to next transforms
  • 9620b91: 8333884: MemorySegment::reinterpret removes read-only property
  • e991c0f: 8335766: Switch case with pattern matching and guard clause compiles inconsistently
  • 6720685: 8335966: Remove incorrect problem listing of java/lang/instrument/NativeMethodPrefixAgent.java in ProblemList-Virtual.txt
  • 4aab58b: 8335637: Add explicit non-null return value expectations to Object.toString()

Please see this link for an up-to-date comparison between the source branch of this pull request and the jdk23 branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the jdk23 branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 86b0cf259fb3cbe3a1973151148e5d36c6a99d91 8334653: ISO 4217 Amendment 177 Update Jul 10, 2024
@openjdk
Copy link

openjdk bot commented Jul 10, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean rfr Pull request is ready for review labels Jul 10, 2024
@openjdk
Copy link

openjdk bot commented Jul 10, 2024

@justin-curtis-lu The following labels will be automatically applied to this pull request:

  • core-libs
  • i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org ready Pull request is ready to be integrated labels Jul 10, 2024
@mlbridge
Copy link

mlbridge bot commented Jul 10, 2024

Webrevs

@Kboxoxx
Copy link

Kboxoxx commented Jul 12, 2024

Hi @Kboxoxx, thanks for making a comment in an OpenJDK project!

All comments and discussions in the OpenJDK Community must be made available under the OpenJDK Terms of Use. If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please Use "Add GitHub user Kboxoxx" for the summary.

If you are not an OpenJDK Author, Committer or Reviewer, simply check the box below to accept the OpenJDK Terms of Use for your comments.

Your comment will be automatically restored once you have accepted the OpenJDK Terms of Use.

@turbanoff
Copy link
Member

turbanoff commented Jul 12, 2024

Please review this PR, which is a backport of commit 86b0cf25 from the openjdk/jdk repository.

This message is kind of confusing. This PR is for openjdk/jdk repository too.

@justin-curtis-lu
Copy link
Member Author

@turbanoff true, I adjusted the message to indicate the original commit is from mainline.

@justin-curtis-lu
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jul 15, 2024

Going to push as commit 5162e1a.
Since your change was applied there have been 13 commits pushed to the jdk23 branch:

  • 908d1e9: 8336259: Wrong link to stylesheet.css in JavaDoc API documentation
  • fd38606: 8325369: @sealedGraph: Bad link to image for tag on nested classes
  • a106e52: 8324841: PKCS11 tests still skip execution
  • 52cd9bb: 8335820: java/lang/invoke/LFCaching/LFSingleThreadCachingTest.java fails due to IllegalArgumentException: hash must be nonzero
  • 7cc50a1: 8334719: (se) Deferred close of SelectableChannel may result in a Selector doing the final close before concurrent I/O on channel has completed
  • cfbfe4a: 8318106: Generated HTML for snippet does not always contain an id
  • d1373a2: 8336036: Synthetic documentation for a record's equals is incorrect for floating-point types
  • 0a9e3bf: 8334418: Update IANA Language Subtag Registry to Version 2024-06-14
  • 06191ac: 8335935: Chained builders not sending transformed models to next transforms
  • 9620b91: 8333884: MemorySegment::reinterpret removes read-only property
  • ... and 3 more: https://git.openjdk.org/jdk/compare/5b9ecb178667e373a834b241b8f8c8a13cef3b4d...jdk23

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 15, 2024
@openjdk openjdk bot closed this Jul 15, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 15, 2024
@openjdk
Copy link

openjdk bot commented Jul 15, 2024

@justin-curtis-lu Pushed as commit 5162e1a.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean core-libs core-libs-dev@openjdk.org i18n i18n-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

5 participants