-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8336036: Synthetic documentation for a record's equals is incorrect for floating-point types #20129
Conversation
👋 Welcome back liach! A progress list of the required criteria for merging this PR into |
@liach This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 13 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
This looks good to me, FWIW. Thanks for the fix! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good.
/integrate |
Going to push as commit b3ef2a6.
Your commit was automatically rebased without conflicts. |
/backport :jdk23 |
@liach the backport was successfully created on the branch backport-liach-b3ef2a60-jdk23 in my personal fork of openjdk/jdk. To create a pull request with this backport targeting openjdk/jdk:jdk23, just click the following link: The title of the pull request is automatically filled in correctly and below you find a suggestion for the pull request body:
If you need to update the source branch of the pull then run the following commands in a local clone of your personal fork of openjdk/jdk:
|
Fixes to Javadoc's default documentation on record classes, that all primitives are compared as if with their wrapper classes'
compare
method by default.Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20129/head:pull/20129
$ git checkout pull/20129
Update a local copy of the PR:
$ git checkout pull/20129
$ git pull https://git.openjdk.org/jdk.git pull/20129/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 20129
View PR using the GUI difftool:
$ git pr show -t 20129
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20129.diff
Webrev
Link to Webrev Comment