Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8258217: PriorityBlockingQueue constructor spec and behavior mismatch #2014

Closed
wants to merge 1 commit into from

Conversation

@Martin-Buchholz
Copy link
Member

@Martin-Buchholz Martin-Buchholz commented Jan 9, 2021

/cc core-libs


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8258217: PriorityBlockingQueue constructor spec and behavior mismatch

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2014/head:pull/2014
$ git checkout pull/2014

@Martin-Buchholz
Copy link
Member Author

@Martin-Buchholz Martin-Buchholz commented Jan 9, 2021

/issue add JDK-8258217

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jan 9, 2021

👋 Welcome back martin! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Jan 9, 2021

@Martin-Buchholz
The core-libs label was successfully added.

@openjdk
Copy link

@openjdk openjdk bot commented Jan 9, 2021

@Martin-Buchholz This issue is referenced in the PR title - it will now be updated.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jan 9, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Jan 10, 2021

@Martin-Buchholz This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8258217: PriorityBlockingQueue constructor spec and behavior mismatch

Reviewed-by: dl

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 1 new commit pushed to the master branch:

  • 81db63e: 8259517: Incorrect test path in test cases

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jan 10, 2021
@Martin-Buchholz
Copy link
Member Author

@Martin-Buchholz Martin-Buchholz commented Jan 10, 2021

/integrate

@openjdk openjdk bot closed this Jan 10, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jan 10, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 10, 2021

@Martin-Buchholz Since your change was applied there have been 2 commits pushed to the master branch:

  • 65ca5c6: 8048109: JToggleButton does not fire actionPerformed under certain conditions
  • 81db63e: 8259517: Incorrect test path in test cases

Your commit was automatically rebased without conflicts.

Pushed as commit 11d5b04.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@Martin-Buchholz
Copy link
Member Author

@Martin-Buchholz Martin-Buchholz commented Jan 10, 2021

/issue add JDK-8258187

@openjdk
Copy link

@openjdk openjdk bot commented Jan 10, 2021

@Martin-Buchholz The command issue can only be used in open pull requests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants