8332600: javac uses record components source position during compilation

[vicente-romero-oracle]

javac uses the source position of record components to find and later probably remove a given record component during compilation. This could be necessary if annotation processors are present. This is done in part to provide better error messages for silly record definitions like:

record R(int i, float i) {} // two record components with the same name

but this is brittle and can backfire if the record is read from a class file as the source positions are not stored there. See JDK-8332297 for some context

The idea of this fix is not to use the source position but only the name to find a given record component. This could imply that if the user defines an erroneous record like the one above, then the record could end up with less record components than expected but records like this wouldn't compile anyway

TIA

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Warning

 ⚠️ Found leading lowercase letter in issue title for 8332600: javac uses record components source position during compilation

Issue

• JDK-8332600: javac uses record components source position during compilation (Bug - P4)

Reviewers

• Jan Lahoda (@lahodaj - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20148/head:pull/20148
$ git checkout pull/20148

Update a local copy of the PR:
$ git checkout pull/20148
$ git pull https://git.openjdk.org/jdk.git pull/20148/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 20148

View PR using the GUI difftool:
$ git pr show -t 20148

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20148.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back vromero! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@vicente-romero-oracle This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8332600: javac uses record components source position during compilation

Reviewed-by: jlahoda

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 77 new commits pushed to the master branch:

• 4a73ed4: 8330144: Revise os::free_memory()
• 35df48e: 8335860: compiler/vectorization/TestFloat16VectorConvChain.java fails with non-standard AVX/SSE settings
• 7bf5313: 8335480: Only deoptimize threads if needed when closing shared arena
• 1b83bd9: 8336661: Parallel: Remove stacks_empty assert in PSScavenge::invoke
• 72297d2: 8317720: RISC-V: Implement Adler32 intrinsic
• 21a6cf8: 8336587: failure_handler lldb command times out on macosx-aarch64 core file
• 78cc0f9: 8336091: Fix HTML warnings in the generated HTML files
• bcb5e69: 8335921: Fix HotSpot VM build without JVMTI
• 10186ff: 8336300: DateFormatSymbols#getInstanceRef returns non-cached instance
• 7ec55df: 8336638: Parallel: Remove redundant mangle in PSScavenge::invoke
• ... and 67 more: https://git.openjdk.org/jdk/compare/5c612c230b0a852aed5fd36e58b82ebf2e1838af...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@vicente-romero-oracle The following label will be automatically applied to this pull request:

• compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (e7647e22)
• 00: Full (49d0ad16)

[lahodaj]

I am afraid recordComponents.head != null (which is basically recordComponents.isEmpty(), I think) is probably insufficient here. Consider e.g.:

record R(int x, int x, int x) {}

which will fail as recordComponents itself will be null, due to tail being null.

Looking at the last record component (.last()) might be one of the solutions?

[vicente-romero-oracle]

I have changed the code a bit, I think it make more sense now, thanks for the comments

[lahodaj]

Seems OK to me.

[vicente-romero-oracle]

thanks for the review

[vicente-romero-oracle]

/integrate

[openjdk]

Going to push as commit 245c086.
Since your change was applied there have been 78 commits pushed to the master branch:

• 5f7b007: 8336346: Fix -Wzero-as-null-pointer-constant warnings in jvmciJavaClasses.cpp
• 4a73ed4: 8330144: Revise os::free_memory()
• 35df48e: 8335860: compiler/vectorization/TestFloat16VectorConvChain.java fails with non-standard AVX/SSE settings
• 7bf5313: 8335480: Only deoptimize threads if needed when closing shared arena
• 1b83bd9: 8336661: Parallel: Remove stacks_empty assert in PSScavenge::invoke
• 72297d2: 8317720: RISC-V: Implement Adler32 intrinsic
• 21a6cf8: 8336587: failure_handler lldb command times out on macosx-aarch64 core file
• 78cc0f9: 8336091: Fix HTML warnings in the generated HTML files
• bcb5e69: 8335921: Fix HotSpot VM build without JVMTI
• 10186ff: 8336300: DateFormatSymbols#getInstanceRef returns non-cached instance
• ... and 68 more: https://git.openjdk.org/jdk/compare/5c612c230b0a852aed5fd36e58b82ebf2e1838af...master

Your commit was automatically rebased without conflicts.

[openjdk]

@vicente-romero-oracle Pushed as commit 245c086.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.