8335927: Revisit AnnotationConstantValueEntry and AnnotationValue.OfConstant

[liach]

Remove AnnotationConstantValueEntry and AnnotationValue.OfConstant.

This is a relic of the old model from openjdk/jdk-sandbox@bb7e294. In addition, this is bug-prone: the byte, short, char, and boolean constants use the int entry, and getting the ConstantDesc for them will return an Integer, which cannot be inversed back into the respective annotation values via AnnotationValue.of(Object) factory.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Change requires CSR request JDK-8336353 to be approved
• Commit message must refer to an issue

Issues

• JDK-8335927: Revisit AnnotationConstantValueEntry and AnnotationValue.OfConstant (Enhancement - P4)
• JDK-8336353: Remove AnnotationConstantValueEntry and AnnotationValue.OfConstant (CSR)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20176/head:pull/20176
$ git checkout pull/20176

Update a local copy of the PR:
$ git checkout pull/20176
$ git pull https://git.openjdk.org/jdk.git pull/20176/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 20176

View PR using the GUI difftool:
$ git pr show -t 20176

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20176.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back liach! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

❗ This change is not yet ready to be integrated.
See the Progress checklist in the description for automated requirements.

[openjdk]

@liach The following labels will be automatically applied to this pull request:

• compiler
• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (3460f207)