Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8253635: Implement toString() for SSLEngineImpl #2019

Closed
wants to merge 3 commits into from

Conversation

@XueleiFan
Copy link
Member

@XueleiFan XueleiFan commented Jan 11, 2021

The SSLSocketImpl and SSLEngineImpl implementation does not override the toString() method. The old code did. BTW, I also made a few code clean up in the SSLSocketImpl.java.

Code clean up, trivial update, no new regression test.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2019/head:pull/2019
$ git checkout pull/2019

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jan 11, 2021

👋 Welcome back xuelei! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

Loading

@openjdk openjdk bot added the rfr label Jan 11, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 11, 2021

@XueleiFan The following label will be automatically applied to this pull request:

  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

Loading

@openjdk openjdk bot added the security label Jan 11, 2021
@mlbridge
Copy link

@mlbridge mlbridge bot commented Jan 11, 2021

Webrevs

Loading

Copy link
Contributor

@coffeys coffeys left a comment

Looks good

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jan 11, 2021

@XueleiFan this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout JDK-8253635
git fetch https://git.openjdk.java.net/jdk master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

Loading

@openjdk
Copy link

@openjdk openjdk bot commented Jan 12, 2021

@XueleiFan This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8253635: Implement toString() for SSLEngineImpl

Reviewed-by: coffeys, wetmore

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

Loading

@openjdk openjdk bot added ready and removed merge-conflict labels Jan 12, 2021
@XueleiFan
Copy link
Member Author

@XueleiFan XueleiFan commented Jan 13, 2021

/integrate

Loading

@openjdk openjdk bot closed this Jan 13, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jan 13, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 13, 2021

@XueleiFan Since your change was applied there have been 5 commits pushed to the master branch:

  • c6d798c: 8259629: aarch64 builds fail after JDK-8258932
  • 4be2173: 8259319: Illegal package access when SunPKCS11 requires SunJCE's classes
  • e4df209: 7018932: Drawing very large coordinates with a dashed Stroke can cause Java to hang
  • 5f7ccce: 8226810: Failed to launch JVM because of NullPointerException occured on System.props
  • d6a2105: 8259343: [macOS] Update JNI error handling in Cocoa code.

Your commit was automatically rebased without conflicts.

Pushed as commit 65bed64.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Loading

@XueleiFan XueleiFan deleted the JDK-8253635 branch Jan 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
3 participants