Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8331194: NPE in ArrayCreationTree.java with -XX:-UseCompressedOops #20210

Conversation

TobiHartmann
Copy link
Member

@TobiHartmann TobiHartmann commented Jul 17, 2024

Hi all,

This pull request contains a backport of commit 005fb67e from the openjdk/jdk repository.

The commit being backported was authored by Cesar Soares Lucas on 16 Jul 2024 and was reviewed by Vladimir Kozlov.

Thanks!


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8331194: NPE in ArrayCreationTree.java with -XX:-UseCompressedOops (Bug - P2)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20210/head:pull/20210
$ git checkout pull/20210

Update a local copy of the PR:
$ git checkout pull/20210
$ git pull https://git.openjdk.org/jdk.git pull/20210/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 20210

View PR using the GUI difftool:
$ git pr show -t 20210

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20210.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 17, 2024

👋 Welcome back thartmann! A progress list of the required criteria for merging this PR into jdk23 will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 17, 2024

@TobiHartmann This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8331194: NPE in ArrayCreationTree.java with -XX:-UseCompressedOops

Reviewed-by: kvn

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the jdk23 branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the jdk23 branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title Backport 005fb67e99370ef2bd15dae621a3924e1cf00124 8331194: NPE in ArrayCreationTree.java with -XX:-UseCompressedOops Jul 17, 2024
@openjdk
Copy link

openjdk bot commented Jul 17, 2024

This backport pull request has now been updated with issue from the original commit.

@openjdk openjdk bot added backport clean rfr Pull request is ready for review labels Jul 17, 2024
@openjdk
Copy link

openjdk bot commented Jul 17, 2024

@TobiHartmann The following label will be automatically applied to this pull request:

  • hotspot-compiler

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the hotspot-compiler hotspot-compiler-dev@openjdk.org label Jul 17, 2024
@mlbridge
Copy link

mlbridge bot commented Jul 17, 2024

Webrevs

Copy link
Contributor

@vnkozlov vnkozlov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 17, 2024
@TobiHartmann
Copy link
Member Author

Thanks for the review, Vladimir!

@TobiHartmann
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jul 17, 2024

Going to push as commit ec1782c.
Since your change was applied there have been 11 commits pushed to the jdk23 branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 17, 2024
@openjdk openjdk bot closed this Jul 17, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 17, 2024
@openjdk
Copy link

openjdk bot commented Jul 17, 2024

@TobiHartmann Pushed as commit ec1782c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport clean hotspot-compiler hotspot-compiler-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

2 participants