8259559: COMPARE_BUILD can't compare patch files

[magicus]

COMPARE_BUILD will fail to run the compare stage, since re-applying an applied patch does not work.

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8259559: COMPARE_BUILD can't compare patch files

Reviewers

• Erik Joelsson (@erikj79 - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2025/head:pull/2025
$ git checkout pull/2025

[bridgekeeper]

👋 Welcome back ihse! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@magicus The following label will be automatically applied to this pull request:

• build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (52b87ea)

[openjdk]

@magicus This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8259559: COMPARE_BUILD can't compare patch files

Reviewed-by: erikj

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 7 new commits pushed to the master branch:

• 33fbc10: 8259025: Record compact constructor using Objects.requireNonNull
• 23801da: 8259482: jni_Set/GetField_probe are the same as their _nh versions
• 01b2804: 8237578: JDK-8214339 (SSLSocketImpl wraps SocketException) appears to not be fully fixed
• 1bd015f: 8258407: Split up CompileJavaModules.gmk into make/modules/$M/Java.gmk
• 2354882: 8250768: javac should be adapted to changes in JEP 12
• 18a37f9: 8259368: Zero: UseCompressedClassPointers does not depend on UseCompressedOops
• a03e22b: 8253910: UseCompressedClassPointers depends on UseCompressedOops in vmError.cpp

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[magicus]

/integrate

[openjdk]

@magicus Since your change was applied there have been 8 commits pushed to the master branch:

• cf3e4bf: 8258838: Remove JVM option UseStackBanging
• 33fbc10: 8259025: Record compact constructor using Objects.requireNonNull
• 23801da: 8259482: jni_Set/GetField_probe are the same as their _nh versions
• 01b2804: 8237578: JDK-8214339 (SSLSocketImpl wraps SocketException) appears to not be fully fixed
• 1bd015f: 8258407: Split up CompileJavaModules.gmk into make/modules/$M/Java.gmk
• 2354882: 8250768: javac should be adapted to changes in JEP 12
• 18a37f9: 8259368: Zero: UseCompressedClassPointers does not depend on UseCompressedOops
• a03e22b: 8253910: UseCompressedClassPointers depends on UseCompressedOops in vmError.cpp

Your commit was automatically rebased without conflicts.

Pushed as commit dab1787.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.