8259563: The CPU model name is printed multiple times when using -Xlog:os+cpu

[wangxues]

Hi all,

The CPU model name will be printed multiple times if the platform only has model name but no flags (such as mips) when using -Xlog:os+cpu. "model_name_printed" should be initialized to "false" before the loop. Please review this trivial change.

Thanks,
Wang Xue

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8259563: The CPU model name is printed multiple times when using -Xlog:os+cpu

Reviewers

• David Holmes (@dholmes-ora - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2026/head:pull/2026
$ git checkout pull/2026

[bridgekeeper]

Hi @wangxues, welcome to this OpenJDK project and thanks for contributing!

We do not recognize you as Contributor and need to ensure you have signed the Oracle Contributor Agreement (OCA). If you have not signed the OCA, please follow the instructions. Please fill in your GitHub username in the "Username" field of the application. Once you have signed the OCA, please let us know by writing /signed in a comment in this pull request.

If you already are an OpenJDK Author, Committer or Reviewer, please click here to open a new issue so that we can record that fact. Please use "Add GitHub user wangxues" as summary for the issue.

If you are contributing this work on behalf of your employer and your employer has signed the OCA, please let us know by writing /covered in a comment in this pull request.

[openjdk]

@wangxues The following label will be automatically applied to this pull request:

• hotspot-runtime

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[wangxues]

/covered
Loongson

[bridgekeeper]

Thank you! Please allow for a few business days to verify that your employer has signed the OCA. Also, please note that pull requests that are pending an OCA check will not usually be evaluated, so your patience is appreciated!

[wangxues]

/help

[openjdk]

@wangxues Available commands:

• cc - add or remove an additional classification label
• contributor - adds or removes additional contributors for a PR
• covered - used when employer has signed the OCA
• csr - require a compatibility and specification request (CSR) for this pull request
• help - shows this text
• integrate - performs integration of the changes in the PR
• issue - edit the list of issues that this PR solves
• label - add or remove an additional classification label
• reviewer - manage additional reviewers for a PR
• reviewers - set the number of additional required reviewers for this PR
• signed - used after signing the OCA
• solves - edit the list of issues that this PR solves
• sponsor - performs integration of a PR that is authored by a non-committer
• summary - updates the summary in the commit message
• test - used to run tests

[wangxues]

/label rfr

[openjdk]

@wangxues The label rfr is not a valid label. These labels are valid:

• serviceability
• hotspot
• sound
• hotspot-compiler
• kulla
• i18n
• shenandoah
• jdk
• javadoc
• 2d
• security
• swing
• hotspot-runtime
• jmx
• build
• nio
• beans
• core-libs
• compiler
• net
• hotspot-gc
• hotspot-jfr
• awt

[mlbridge]

Webrevs

• 00: Full (6adc4e6)

[wangxues]

/test

[openjdk]

@wangxues you need to get approval to run the tests in tier1 for commits up until 6adc4e6

[dholmes-ora]

Looks good and trivial.

Thanks,
David

[openjdk]

⚠️ @wangxues the full name on your profile does not match the author name in this pull requests' HEAD commit. If this pull request gets integrated then the author name from this pull requests' HEAD commit will be used for the resulting commit. If you wish to push a new commit with a different author name, then please run the following commands in a local repository of your personal fork:

$ git checkout fix-model-name-print
$ git commit -c user.name='Preferred Full Name' --allow-empty -m 'Update full name'
$ git push

[openjdk]

@wangxues This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8259563: The CPU model name is printed multiple times when using -Xlog:os+cpu

Reviewed-by: dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 81 new commits pushed to the master branch:

• 8b8b1f9: 8259706: C2 compilation fails with assert(vtable_index == Method::invalid_vtable_index) failed: correct sentinel value
• ae9187d: 8256109: Create implementation for NSAccessibilityButton protocol
• 5513f98: 8258010: Debug build failure with clang-10 due to -Wdeprecated-copy
• 51e14f2: Merge
• 5926d75: 8259719: ProblemList runtime/cds/appcds/jigsaw/modulepath/ModulePathAndCP_JFR.java on Windows
• 8abefde: 8259720: ProblemList java/awt/Focus/AppletInitialFocusTest/AppletInitialFocusTest1.java on Windows
• fb8ac24: 8259722: ProblemList two jdk/jfr/startupargs tests on Windows
• ac4cd2e: 8231461: static/instance overload leads to 'unexpected static method found in unbound lookup' when resolving method reference
• 42d2d6d: 8259063: Possible deadlock with vtable/itable creation vs concurrent class unloading
• 6bb6093: 8259657: typo in generated HELP page prevents localization
• ... and 71 more: https://git.openjdk.java.net/jdk/compare/235488215bb1e71174abff34192ab222c2c7047a...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@dholmes-ora) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[wangxues]

/integrate

[openjdk]

@wangxues
Your change (at version 6adc4e6) is now ready to be sponsored by a Committer.

[wangxues]

@dholmes-ora Thanks for your review. Could you please sponsor it for me?

Thanks,
Wang Xue

[dholmes-ora]

/sponsor

[openjdk]

@dholmes-ora @wangxues Since your change was applied there have been 83 commits pushed to the master branch:

• b040a3d: 8259631: Reapply pattern match instanceof use in HttpClientImpl
• 3462f7a: 8256955: Move includes of events.hpp out of header files
• 8b8b1f9: 8259706: C2 compilation fails with assert(vtable_index == Method::invalid_vtable_index) failed: correct sentinel value
• ae9187d: 8256109: Create implementation for NSAccessibilityButton protocol
• 5513f98: 8258010: Debug build failure with clang-10 due to -Wdeprecated-copy
• 51e14f2: Merge
• 5926d75: 8259719: ProblemList runtime/cds/appcds/jigsaw/modulepath/ModulePathAndCP_JFR.java on Windows
• 8abefde: 8259720: ProblemList java/awt/Focus/AppletInitialFocusTest/AppletInitialFocusTest1.java on Windows
• fb8ac24: 8259722: ProblemList two jdk/jfr/startupargs tests on Windows
• ac4cd2e: 8231461: static/instance overload leads to 'unexpected static method found in unbound lookup' when resolving method reference
• ... and 73 more: https://git.openjdk.java.net/jdk/compare/235488215bb1e71174abff34192ab222c2c7047a...master

Your commit was automatically rebased without conflicts.

Pushed as commit b8ef2ba.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.