-
Notifications
You must be signed in to change notification settings - Fork 6.2k
JDK-8331859 : [PPC64] Remove support for Power7 and older #20262
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Welcome back sroy! A progress list of the required criteria for merging this PR into |
|
@suchismith1993 This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 163 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@TheRealMDoerr) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
|
@suchismith1993 The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
8a75a19 to
b05ef18
Compare
|
@suchismith1993 This pull request has been inactive for more than 8 weeks and will be automatically closed if another 8 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration! |
|
@suchismith1993 This pull request has been inactive for more than 16 weeks and will now be automatically closed. If you would like to continue working on this pull request in the future, feel free to reopen it! This can be done using the |
|
/open |
|
@suchismith1993 This pull request is now open |
|
@suchismith1993 this pull request can not be integrated into git checkout power8
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push |
TheRealMDoerr
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. We'll retest it. 2nd review needed.
| "ppc64%s%s%s%s", | ||
| (" sha"), | ||
| (" aes"), | ||
| "ppc64 sha aes%s%s%s%s", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is now broken! Too many %s!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah. Sorry about that. For some reason the files are not getting saved in the machine and older versions were getting pushed. Fixed now.
dbriemann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice cleanup. I have some small suggestions.
|
|
||
| // Prefetch the data into the L2 cache. | ||
| __ dcbt(R3_ARG1, 0); | ||
| // If supported set DSCR pre-fetch to deepest. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The If supported can be removed from the comment.
dbriemann
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. LGTM
|
/integrate |
|
@suchismith1993 |
|
/sponsor |
|
Going to push as commit 5cdeef8.
Your commit was automatically rebased without conflicts. |
|
@varada1110 @suchismith1993 Pushed as commit 5cdeef8. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
|
Hi, I came across VM crash with SIGILL after this patch. My local test environmentAs I don't hava ppc64 hardware, I built one The unsupported instruction is
|
|
@shqking: Thanks for the detailed analysis! Not sure if it is a QEMU bug. If this is the only problem, let's just add the check back. See new PR linked above. Can you verify and review it, please? |
JBS Issue: JDK-8331859
Linux PPC64le requires Power8 since the beginning.
AIX requires Power8 with the new OpenXL based build (JDK-8307520). The old build has been removed in JDK 23 (JDK-8327701).
Linux PPC64 Big Endian is no longer officially supported (only kept alive for development, debugging and testing purposes).
The following checks for old processors are no longer needed:
8: VM_Version::has_lqarx()
7: VM_Version::has_popcntw()
6: VM_Version::has_cmpb()
5: VM_Version::has_popcntb()
These ones and some more checks for old instructions are no longer needed. All code which is no longer reachable when removing them should also get removed.
Checks like "PowerArchitecturePPC64 >= 8" (or older) can be removed.
Atomic::PlatformCmpxchg<1>::operator() can be simplified by using sub-word instructions (lharx, lbarx).
Temp registers can be removed from cmpxchgb and cmpxchgh.
Build flags "-mcpu=powerpc64 -mtune=power5" for Big Endian linux should get replaced by "-mcpu=power8 -mtune=power8" as already used for linux PPC64le.
Progress
Issue
Reviewers
Reviewers without OpenJDK IDs
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20262/head:pull/20262$ git checkout pull/20262Update a local copy of the PR:
$ git checkout pull/20262$ git pull https://git.openjdk.org/jdk.git pull/20262/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 20262View PR using the GUI difftool:
$ git pr show -t 20262Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20262.diff
Using Webrev
Link to Webrev Comment