8259565: Zero: compiler/runtime/criticalnatives fails because CriticalJNINatives is not supported

[shipilev]

Zero does not support CriticalJNINatives (and that flag is going away soon), and so the tests are failing with:

$ CONF=linux-x86_64-zero-fastdebug make exploded-run-test TEST=compiler/runtime/criticalnatives/
java.lang.Exception: critical native lookup failed
at compiler.runtime.criticalnatives.argumentcorruption.CheckLongArgs.check(CheckLongArgs.java:58)
at compiler.runtime.criticalnatives.argumentcorruption.CheckLongArgs.test(CheckLongArgs.java:48)
at compiler.runtime.criticalnatives.argumentcorruption.CheckLongArgs.main(CheckLongArgs.java:38)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:78)
at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
at java.base/java.lang.reflect.Method.invoke(Method.java:567)
at com.sun.javatest.regtest.agent.MainWrapper$MainThread.run(MainWrapper.java:127)
at java.base/java.lang.Thread.run(Thread.java:831)

There are similar issues for AArch64 (JDK-8191129) and ARM32 (JDK-8213794). Zero needs the same.

Additional testing:

• Linux x86_64 Zero compiler/runtime/criticalnatives (now skipped)
• Linux x86_64 Server compiler/runtime/criticalnatives (still run and pass)

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed

Issue

• JDK-8259565: Zero: compiler/runtime/criticalnatives fails because CriticalJNINatives is not supported

Reviewers

• Coleen Phillimore (@coleenp - Reviewer)
• Zhengyu Gu (@zhengyu123 - Reviewer)

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2027/head:pull/2027
$ git checkout pull/2027

[bridgekeeper]

👋 Welcome back shade! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@shipilev The following label will be automatically applied to this pull request:

• hotspot

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (821a901)

[coleenp]

Looks good and can be pushed under the trivial rules.

[openjdk]

@shipilev This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8259565: Zero: compiler/runtime/criticalnatives fails because CriticalJNINatives is not supported

Reviewed-by: coleenp, zgu

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

• 33fbc10: 8259025: Record compact constructor using Objects.requireNonNull
• 23801da: 8259482: jni_Set/GetField_probe are the same as their _nh versions
• 01b2804: 8237578: JDK-8214339 (SSLSocketImpl wraps SocketException) appears to not be fully fixed
• 1bd015f: 8258407: Split up CompileJavaModules.gmk into make/modules/$M/Java.gmk
• 2354882: 8250768: javac should be adapted to changes in JEP 12

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[zhengyu123]

Looks good.

[shipilev]

/integrate

[openjdk]

@shipilev Since your change was applied there have been 28 commits pushed to the master branch:

• 98ccfbf: 8255710: Opensource unit/regression tests for CMM
• 61c5b95: 7194219: java/awt/Component/UpdatingBootTime/UpdatingBootTime.html fails on Linux
• 77f6290: 8258254: Move PtrQueue flush to PtrQueueSet subclasses
• 2255ab7: 8258810: Improve enum traits
• ae0532e: 8259044: JVM lacks data type qualifier when using -XX:+PrintAssembly with AArch64-Neon backend
• b378f54: Merge
• 2cb271e: 8253996: Javac error on jdk16 build 18: invalid flag: -Xdoclint:-missing
• d60a937: 8259028: ClassCastException when using custom filesystem with wrapper FileChannel impl
• e05f36f: 8259043: More Zero architectures need linkage with libatomic
• 020ec84: 8259429: Update reference to README.md
• ... and 18 more: https://git.openjdk.java.net/jdk/compare/18a37f9453cd1a5740da47b93ce6122052ccd43b...master

Your commit was automatically rebased without conflicts.

Pushed as commit 9d4e84f.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.