Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8259528: Broken Link for [java.text.Normalizer.Form] #2028

Closed
wants to merge 1 commit into from

Conversation

@naotoj
Copy link
Member

@naotoj naotoj commented Jan 11, 2021

Please review this simple doc fix.


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8259528: Broken Link for [java.text.Normalizer.Form]

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2028/head:pull/2028
$ git checkout pull/2028

@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jan 11, 2021

👋 Welcome back naoto! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk openjdk bot added the rfr label Jan 11, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 11, 2021

@naotoj The following labels will be automatically applied to this pull request:

  • core-libs
  • i18n

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jan 11, 2021

Webrevs

@openjdk
Copy link

@openjdk openjdk bot commented Jan 11, 2021

@naotoj This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8259528: Broken Link for [java.text.Normalizer.Form]

Reviewed-by: lancea, joehw, iris

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 5 new commits pushed to the master branch:

  • d9f2134: 8258655: remove <-- NewPage --> comment from generated pages
  • c956e7a: 8258659: Eliminate whitespace comments from generated pages
  • 3861960: 8258426: Split up autoconf/version-numbers and move it to conf dir
  • dab1787: 8259559: COMPARE_BUILD can't compare patch files
  • cf3e4bf: 8258838: Remove JVM option UseStackBanging

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jan 11, 2021
Copy link
Member

@JoeWang-Java JoeWang-Java left a comment

Oops, forgot to submit the review ;-)

@naotoj
Copy link
Member Author

@naotoj naotoj commented Jan 11, 2021

/integrate

@openjdk openjdk bot closed this Jan 11, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jan 11, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 11, 2021

@naotoj Since your change was applied there have been 7 commits pushed to the master branch:

  • e9929e2: 8259582: Backout JDK-8237578 until all affected tests have been fixed
  • 8dfc77b: 8259586: ProblemList dll_address_to_function_and_library_name
  • d9f2134: 8258655: remove <-- NewPage --> comment from generated pages
  • c956e7a: 8258659: Eliminate whitespace comments from generated pages
  • 3861960: 8258426: Split up autoconf/version-numbers and move it to conf dir
  • dab1787: 8259559: COMPARE_BUILD can't compare patch files
  • cf3e4bf: 8258838: Remove JVM option UseStackBanging

Your commit was automatically rebased without conflicts.

Pushed as commit cd73939.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
4 participants