8336928: GHA: Bundle artifacts removal broken

[zzambers]

GHA code, which tries to remove bundle artifacts no longer works. It probably broke after JDK-8324723 (GHA: Upgrade some actions to avoid deprecated Node 16).

Details:
Seems like there were some backend architecture changes in artifact actions in v4. As result old code to remove artifacts no longer works. However there is REST API available, which works.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8336928: GHA: Bundle artifacts removal broken (Bug - P4)

Reviewers

• Magnus Ihse Bursie (@magicus - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20281/head:pull/20281
$ git checkout pull/20281

Update a local copy of the PR:
$ git checkout pull/20281
$ git pull https://git.openjdk.org/jdk.git pull/20281/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 20281

View PR using the GUI difftool:
$ git pr show -t 20281

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20281.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back zzambers! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@zzambers This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8336928: GHA: Bundle artifacts removal broken

Reviewed-by: ihse

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 141 new commits pushed to the master branch:

• 2e093b0: 8337779: test/jdk/jdk/jfr/jvm/TestHiddenWait.java is a bit fragile
• d3e7b0c: 8336462: ConcurrentSkipListSet Javadoc incorrectly warns about size method complexity
• be34730: 8335257: Refactor code to create Initialized Assertion Predicates into separate class
• fbe8a81: 8333144: docker tests do not work when ubsan is configured
• dabdae6: 8334599: Improve code from JDK-8302671
• 8bd3cd5: 8337716: ByteBuffer hashCode implementations are inconsistent
• 367e0a6: 8334755: Asymptotically faster implementation of square root algorithm
• 34edc73: 8337396: Cleanup usage of ExternalAddess
• 7deee74: 8335122: Reorganize internal low-level support for HTML in jdk.javadoc
• f2e1205: 8337676: JFR: Change the label of the throttle setting
• ... and 131 more: https://git.openjdk.org/jdk/compare/c1fdc04ad78e6e4712f2173370012106f9cc45ee...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@magicus) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

[openjdk]

@zzambers The following label will be automatically applied to this pull request:

• build

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (81c5e314)
• 00: Full (6b5d265c)

[magicus]

The code looks sane. Have you been able to test this? (Trying out GHA changes is sometimes a bit tricky)

[zzambers]

@magicus I have tested it by having GHA enabled on my fork/branch, as usual. I can see that right number of artifacts has been removed in "Remove bundle artifacts" step. And there are no "bundles-*" artifacts in Summary. (Unlike in other test runs, without this change, e.g. here.)

[magicus]

Great, thanks! The build system does not need a secondary review so you are free to integrate.

[zzambers]

@magicus thanks
/integrate

[openjdk]

@zzambers
Your change (at version 81c5e31) is now ready to be sponsored by a Committer.

[magicus]

/sponsor

[openjdk]

Going to push as commit 9856216.
Since your change was applied there have been 145 commits pushed to the master branch:

• 219e1eb: 8337712: Wrong javadoc in java.util.Date#toString(): "61" and right parenthesis
• 97afbd9: 8336410: runtime/NMT/TotalMallocMmapDiffTest.java Total malloc diff is incorrect. Expected malloc diff range
• c095c0e: 8336489: Track scoped accesses in JVMCI compiled code
• 7e925d7: 8337283: configure.log is truncated when build dir is on different filesystem
• 2e093b0: 8337779: test/jdk/jdk/jfr/jvm/TestHiddenWait.java is a bit fragile
• d3e7b0c: 8336462: ConcurrentSkipListSet Javadoc incorrectly warns about size method complexity
• be34730: 8335257: Refactor code to create Initialized Assertion Predicates into separate class
• fbe8a81: 8333144: docker tests do not work when ubsan is configured
• dabdae6: 8334599: Improve code from JDK-8302671
• 8bd3cd5: 8337716: ByteBuffer hashCode implementations are inconsistent
• ... and 135 more: https://git.openjdk.org/jdk/compare/c1fdc04ad78e6e4712f2173370012106f9cc45ee...master

Your commit was automatically rebased without conflicts.

[openjdk]

@magicus @zzambers Pushed as commit 9856216.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.