8336935: Test sun/security/krb5/auto/RealmSpecificValues.java fails: java.lang.RuntimeException: Should not reach here

[wangweij]

The test sets system properties. Should run in othervm.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8336935: Test sun/security/krb5/auto/RealmSpecificValues.java fails: java.lang.RuntimeException: Should not reach here (Bug - P4)

Reviewers

• Hai-May Chao (@haimaychao - Committer)
• David Holmes (@dholmes-ora - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20284/head:pull/20284
$ git checkout pull/20284

Update a local copy of the PR:
$ git checkout pull/20284
$ git pull https://git.openjdk.org/jdk.git pull/20284/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 20284

View PR using the GUI difftool:
$ git pr show -t 20284

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20284.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back weijun! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@wangweij This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8336935: Test sun/security/krb5/auto/RealmSpecificValues.java fails: java.lang.RuntimeException: Should not reach here

Reviewed-by: hchao, dholmes

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@wangweij The following label will be automatically applied to this pull request:

• security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 00: Full (a546a83f)

[dholmes-ora]

Seems reasonable. I assume the actual conf file being written will be in the test's scratch directory so no interference possible with other tests?

[wangweij]

Seems reasonable. I assume the actual conf file being written will be in the test's scratch directory so no interference possible with other tests?

Yes.

[wangweij]

/integrate

[openjdk]

Going to push as commit d63d6e2.

[openjdk]

@wangweij Pushed as commit d63d6e2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.