Skip to content

8204582: Extra spaces in jlink documentation make it incorrect.#20292

Closed
sundararajana wants to merge 2 commits intoopenjdk:masterfrom
sundararajana:JDK-8204582
Closed

8204582: Extra spaces in jlink documentation make it incorrect.#20292
sundararajana wants to merge 2 commits intoopenjdk:masterfrom
sundararajana:JDK-8204582

Conversation

@sundararajana
Copy link
Member

@sundararajana sundararajana commented Jul 23, 2024

removed extra whitespaces


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Warning

 ⚠️ Found trailing period in issue title for 8204582: Extra spaces in jlink documentation make it incorrect.

Issue

  • JDK-8204582: Extra spaces in jlink documentation make it incorrect. (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20292/head:pull/20292
$ git checkout pull/20292

Update a local copy of the PR:
$ git checkout pull/20292
$ git pull https://git.openjdk.org/jdk.git pull/20292/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 20292

View PR using the GUI difftool:
$ git pr show -t 20292

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20292.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 23, 2024

👋 Welcome back sundar! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 23, 2024

@sundararajana This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8204582: Extra spaces in jlink documentation make it incorrect.

Reviewed-by: alanb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 4 new commits pushed to the master branch:

  • 4c7b3e7: 8334758: Incorrect note in Javadoc for a few RandomGenerator methods
  • 48030a2: 8336855: Duplicate protected declaration and comment in interp_masm_aarch64.hpp
  • 9f03f68: 8336339: (se) SelectionKey.interestOps(int) should not throw ClosedSelectorException
  • 22914e0: 8335938: Review XxxBuilder.original and XxxModel.parent

Please see this link for an up-to-date comparison between the source branch of this pull request and the master branch.
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot changed the title 8204582: Extra spaces in jlink documentation make it incorrect 8204582: Extra spaces in jlink documentation make it incorrect. Jul 23, 2024
@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 23, 2024
@openjdk
Copy link

openjdk bot commented Jul 23, 2024

@sundararajana The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Jul 23, 2024
@mlbridge
Copy link

mlbridge bot commented Jul 23, 2024

Webrevs

@AlanBateman
Copy link
Contributor

Are you going to update --limit-modules too?

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 23, 2024
@sundararajana
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Jul 23, 2024

Going to push as commit 0e555b5.
Since your change was applied there have been 6 commits pushed to the master branch:

  • a2a236f: 8335939: Hide element writing across the ClassFile API
  • e83b4b2: 8335182: Consolidate and streamline String concat code shapes
  • 4c7b3e7: 8334758: Incorrect note in Javadoc for a few RandomGenerator methods
  • 48030a2: 8336855: Duplicate protected declaration and comment in interp_masm_aarch64.hpp
  • 9f03f68: 8336339: (se) SelectionKey.interestOps(int) should not throw ClosedSelectorException
  • 22914e0: 8335938: Review XxxBuilder.original and XxxModel.parent

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 23, 2024
@openjdk openjdk bot closed this Jul 23, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jul 23, 2024
@openjdk
Copy link

openjdk bot commented Jul 23, 2024

@sundararajana Pushed as commit 0e555b5.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants