Skip to content

8339972: Make a few fields in SortingFocusTraversalPolicy static #20327

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

turbanoff
Copy link
Member

@turbanoff turbanoff commented Jul 25, 2024

2 fields in javax.swing.SortingFocusTraversalPolicy could be made 'static':

  1. FORWARD_TRAVERSAL = 0
  2. BACKWARD_TRAVERSAL = 1

Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8339972: Make a few fields in SortingFocusTraversalPolicy static (Enhancement - P5)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20327/head:pull/20327
$ git checkout pull/20327

Update a local copy of the PR:
$ git checkout pull/20327
$ git pull https://git.openjdk.org/jdk.git pull/20327/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 20327

View PR using the GUI difftool:
$ git pr show -t 20327

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20327.diff

Webrev

Link to Webrev Comment

2 fields in javax.swing.SortingFocusTraversalPolicy could be made 'static':
1. FORWARD_TRAVERSAL = 0
2. BACKWARD_TRAVERSAL = 1
@bridgekeeper
Copy link

bridgekeeper bot commented Jul 25, 2024

👋 Welcome back aturbanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 25, 2024

@turbanoff This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8339972: Make a few fields in SortingFocusTraversalPolicy static

Reviewed-by: azvegint, aivanov

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 634 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk
Copy link

openjdk bot commented Jul 25, 2024

@turbanoff The following label will be automatically applied to this pull request:

  • client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the client client-libs-dev@openjdk.org label Jul 25, 2024
@bridgekeeper
Copy link

bridgekeeper bot commented Aug 22, 2024

@turbanoff This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

@turbanoff turbanoff changed the title [PATCH] Make a few fields in SortingFocusTraversalPolicy static 8339972: Make a few fields in SortingFocusTraversalPolicy static Sep 11, 2024
@openjdk openjdk bot added the rfr Pull request is ready for review label Sep 11, 2024
@mlbridge
Copy link

mlbridge bot commented Sep 11, 2024

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Sep 12, 2024
@turbanoff
Copy link
Member Author

Any more reviewers? I will integrate tomorrow.

@turbanoff
Copy link
Member Author

/integrate

@openjdk
Copy link

openjdk bot commented Sep 20, 2024

Going to push as commit fe80618.
Since your change was applied there have been 635 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Sep 20, 2024
@openjdk openjdk bot closed this Sep 20, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Sep 20, 2024
@openjdk
Copy link

openjdk bot commented Sep 20, 2024

@turbanoff Pushed as commit fe80618.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
client client-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants