8339017: Make a couple of fields in DoubleByte static

[turbanoff]

3 fields in sun.nio.cs.DoubleByte.{Encoder,Decoder} could be made 'static':

1. SS2
2. SS3
3. MAX_SINGLEBYTE

---

Progress

• Change must not contain extraneous whitespace
• Commit message must refer to an issue
• Change must be properly reviewed (2 reviews required, with at least 1 Reviewer, 1 Author)

Issue

• JDK-8339017: Make a couple of fields in DoubleByte static (Enhancement - P5)

Reviewers

• Brian Burkhalter (@bplb - Reviewer)
• Naoto Sato (@naotoj - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20329/head:pull/20329
$ git checkout pull/20329

Update a local copy of the PR:
$ git checkout pull/20329
$ git pull https://git.openjdk.org/jdk.git pull/20329/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 20329

View PR using the GUI difftool:
$ git pr show -t 20329

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20329.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back aturbanov! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[openjdk]

@turbanoff This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8339017: Make a couple of fields in DoubleByte static

Reviewed-by: bpb, naoto

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 333 new commits pushed to the master branch:

• b1b4cd4: 8332158: [XWayland] test/jdk/java/awt/Mouse/EnterExitEvents/ResizingFrameTest.java
• 284c3cd: 8336299: Improve GCLocker stall diagnostics
• 2e96f15: 8338489: Typo in MemorySegment doc
• 44d3a68: 8314124: RISC-V: implement Base64 intrinsic - decoding
• daf2617: 8338929: Make Metaspace::deallocate space-aware
• fa4ff78: 8338690: CompactNumberInstance.format incorrectly formats some numbers (few vs many)
• 1ff5f8d: 8338440: Parallel: Improve fragmentation mitigation in Full GC
• 0f66710: 8338939: Simplify processing of hidden class names
• b25095b: 8338728: Misc issues in memory layout javadoc
• 414d23c: 8338765: ScheduledThreadPoolExecutor struggles with extremely long delays
• ... and 323 more: https://git.openjdk.org/jdk/compare/3baff2af6a30cc6cb2e0d4391db1cf7e61c33f64...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@turbanoff The following label will be automatically applied to this pull request:

• nio

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[bridgekeeper]

@turbanoff This pull request has been inactive for more than 4 weeks and will be automatically closed if another 4 weeks passes without any activity. To avoid this, simply add a new comment to the pull request. Feel free to ask for assistance if you need help with progressing this pull request towards integration!

[AlanBateman]

Yes it can be static.

[mlbridge]

Webrevs

• 00: Full (cdf05e26)

[bplb]

Looks all right but I think @naotoj might like to review it as well.

[bplb]

/reviewers 2

[openjdk]

@bplb
The total number of required reviews for this PR (including the jcheck configuration and the last /reviewers command) is now set to 2 (with at least 1 Reviewer, 1 Author).

[naotoj]

LGTM

[turbanoff]

/integrate

[openjdk]

Going to push as commit d35ffa4.
Since your change was applied there have been 359 commits pushed to the master branch:

• 723588a: 8338569: HTTP/1.1 CleanupTrigger may be triggerred after the next exchange started
• 362f9ce: 8339120: Use more fine-granular gcc unused warnings
• f080b4b: 8333098: ubsan: bytecodeInfo.cpp:318:59: runtime error: division by zero
• ff59532: 8338678: Erroneous parameterized type represented as
• 0b4a7d5: 8324859: Improve error recovery
• 1383fec: 8327381: Refactor type-improving transformations in BoolNode::Ideal to BoolNode::Value
• eb7ead5: 8336873: BasicSplitPaneDivider:oneTouchExpandableChanged() should mention that implementation depends on SplitPane.supportsOneTouchButtons property
• 0ddcd70: 8335120: assert(!target->can_be_statically_bound() || target == cha_monomorphic_target) failed
• 26e3d53: 8338716: Re-visit "interrupt handling" in jdk.internal.loader.Resource
• 72a4900: 8338888: SystemDictionary::class_name_symbol has incorrect length check
• ... and 349 more: https://git.openjdk.org/jdk/compare/3baff2af6a30cc6cb2e0d4391db1cf7e61c33f64...master

Your commit was automatically rebased without conflicts.

[openjdk]

@turbanoff Pushed as commit d35ffa4.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.