Skip to content

8337245: Fix wrong comment of StringConcatHelper #20344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

wenshao
Copy link
Contributor

@wenshao wenshao commented Jul 26, 2024


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8337245: Fix wrong comment of StringConcatHelper (Enhancement - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20344/head:pull/20344
$ git checkout pull/20344

Update a local copy of the PR:
$ git checkout pull/20344
$ git pull https://git.openjdk.org/jdk.git pull/20344/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 20344

View PR using the GUI difftool:
$ git pr show -t 20344

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20344.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 26, 2024

👋 Welcome back wenshao! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 26, 2024

@wenshao This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8337245: Fix wrong comment of StringConcatHelper

Reviewed-by: phh, redestad

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 16 new commits pushed to the master branch:

  • 034297a: 8336240: Test com/sun/crypto/provider/Cipher/DES/PerformanceTest.java fails with java.lang.ArithmeticException
  • abc4ca5: 8330427: Obsolete -XX:+PreserveAllAnnotations
  • 0c3720b: 8335131: Test "javax/swing/JColorChooser/Test6977726.java" failed on ubuntu x64 because "Preview" title is missing for GTK L&F
  • 4f194f1: 8337241: Shenandoah: Normalize include guards
  • f35af71: 8334315: Shenandoah: reduce GC logging noise
  • 4bcb8f0: 8337243: Fix more -Wzero-as-null-pointer-constant warnings in compiler code
  • 3abe8a6: 8336663: [JVMCI] VM Crash on ZGC due to incompatible handle returned by HotSpotJVMCIRuntime#getJObjectValue
  • 5ff7c57: 8337168: Optimize LocalDateTime.toString
  • 374fca0: 8335967: "text-decoration: none" does not work with "A" HTML tags
  • 2aeb12e: 8334482: Shenandoah: Deadlock when safepoint is pending during nmethods iteration
  • ... and 6 more: https://git.openjdk.org/jdk/compare/8c28f25e1383f10a78b05e47ccf1cc4262069e69...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@phohensee, @cl4es) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk
Copy link

openjdk bot commented Jul 26, 2024

@wenshao The following label will be automatically applied to this pull request:

  • core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added the core-libs core-libs-dev@openjdk.org label Jul 26, 2024
@wenshao wenshao changed the title Fix wrong comment of StringConcatHelper 8337245: Fix wrong comment of StringConcatHelper Jul 26, 2024
@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 26, 2024
@mlbridge
Copy link

mlbridge bot commented Jul 26, 2024

Webrevs

Copy link
Member

@phohensee phohensee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Trivial.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jul 26, 2024
@wenshao
Copy link
Contributor Author

wenshao commented Jul 27, 2024

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Jul 27, 2024
@openjdk
Copy link

openjdk bot commented Jul 27, 2024

@wenshao
Your change (at version d453e6c) is now ready to be sponsored by a Committer.

@cl4es
Copy link
Member

cl4es commented Jul 27, 2024

/sponsor

@openjdk
Copy link

openjdk bot commented Jul 27, 2024

Going to push as commit 2fbdbac.
Since your change was applied there have been 16 commits pushed to the master branch:

  • 034297a: 8336240: Test com/sun/crypto/provider/Cipher/DES/PerformanceTest.java fails with java.lang.ArithmeticException
  • abc4ca5: 8330427: Obsolete -XX:+PreserveAllAnnotations
  • 0c3720b: 8335131: Test "javax/swing/JColorChooser/Test6977726.java" failed on ubuntu x64 because "Preview" title is missing for GTK L&F
  • 4f194f1: 8337241: Shenandoah: Normalize include guards
  • f35af71: 8334315: Shenandoah: reduce GC logging noise
  • 4bcb8f0: 8337243: Fix more -Wzero-as-null-pointer-constant warnings in compiler code
  • 3abe8a6: 8336663: [JVMCI] VM Crash on ZGC due to incompatible handle returned by HotSpotJVMCIRuntime#getJObjectValue
  • 5ff7c57: 8337168: Optimize LocalDateTime.toString
  • 374fca0: 8335967: "text-decoration: none" does not work with "A" HTML tags
  • 2aeb12e: 8334482: Shenandoah: Deadlock when safepoint is pending during nmethods iteration
  • ... and 6 more: https://git.openjdk.org/jdk/compare/8c28f25e1383f10a78b05e47ccf1cc4262069e69...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Jul 27, 2024
@openjdk openjdk bot closed this Jul 27, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Jul 27, 2024
@openjdk
Copy link

openjdk bot commented Jul 27, 2024

@cl4es @wenshao Pushed as commit 2fbdbac.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core-libs core-libs-dev@openjdk.org integrated Pull request has been integrated
Development

Successfully merging this pull request may close these issues.

3 participants