-
Notifications
You must be signed in to change notification settings - Fork 5.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8337840: Remove redundant null check in ObjectOutputStream.writeProxyDesc #20351
8337840: Remove redundant null check in ObjectOutputStream.writeProxyDesc #20351
Conversation
There is implicit null check in line before this: Class<?>[] ifaces = cl.getInterfaces(); 'cl' can't be null after that.
👋 Welcome back aturbanov! A progress list of the required criteria for merging this PR into |
@turbanoff This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 112 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
@turbanoff The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
That null check appears to have been added as part of https://mail.openjdk.org/pipermail/core-libs-dev/2014-April/026379.html. The change in that previous commit introduced 2 null checks - one in Having said that, I think we might have to consider if that null check needs to be moved just after the call to I would wait for Roger or someone more familiar with this area to recommend what needs to be done here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Hotspot would have elided this check anyway based on the previous implicit check.
The review overhead is higher than the value add to the source.
Thank you for review! /integrate |
Going to push as commit 82d5768.
Your commit was automatically rebased without conflicts. |
@turbanoff Pushed as commit 82d5768. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
There is implicit null check in line before.
jdk/src/java.base/share/classes/java/io/ObjectOutputStream.java
Lines 1267 to 1277 in 431d4f7
'cl' can't be null after that.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20351/head:pull/20351
$ git checkout pull/20351
Update a local copy of the PR:
$ git checkout pull/20351
$ git pull https://git.openjdk.org/jdk.git pull/20351/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 20351
View PR using the GUI difftool:
$ git pr show -t 20351
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20351.diff
Webrev
Link to Webrev Comment