8235404: [macos] JOptionPane blocks drawing string on another component #20359

alisenchung · 2024-07-26T16:52:44Z

Currently if you try to use graphics to draw a string on a frame using JOptionPane + JTextField with a listener as a prompt, the string will not draw. Adding a repaint after dialog.dispose in JOptionPane will cause the text to show after the dialog is closed.

Progress

Change must be properly reviewed (1 review required, with at least 1 Reviewer)
Change must not contain extraneous whitespace
Commit message must refer to an issue

Issue

JDK-8235404: [macos] JOptionPane blocks drawing string on another component (Bug - P4)

Reviewers

Harshitha Onkar (@honkar-jdk - Reviewer)
Damon Nguyen (@DamonGuy - Committer) 🔄 Re-review required (review applies to 84d62d5e)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20359/head:pull/20359
$ git checkout pull/20359

Update a local copy of the PR:
$ git checkout pull/20359
$ git pull https://git.openjdk.org/jdk.git pull/20359/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 20359

View PR using the GUI difftool:
$ git pr show -t 20359

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20359.diff

Webrev

Link to Webrev Comment

bridgekeeper · 2024-07-26T16:53:38Z

👋 Welcome back achung! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

openjdk · 2024-07-26T16:55:06Z

@alisenchung This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8235404: [macos] JOptionPane blocks drawing string on another component

Reviewed-by: honkar, dnguyen

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 668 new commits pushed to the master branch:

22a3421: 8337786: Fix simple -Wzero-as-null-pointer-constant warnings in aarch64 code
ff634a9: 8337506: Disable "best-fit" mapping on Windows command line
3f8b3e5: 8337887: [JVMCI] Clarify jdk.vm.ci.code.Architecture.getName javadoc
53db937: 8337780: RISC-V: C2: Change C calling convention for sp to NS
ab509f1: 8337654: Relocate uncommon trap stub from SharedRuntime to OptoRuntime
1348ece: 8332120: Potential compilation failure in istream.cpp:205 - loss of data on conversion
ef909bd: 8335121: Native memory leak when not recording any events
a117945: 8337344: Redundant javadoc at RasterPrinterJob.isCancelled
f9b8a22: 8337798: JFR: Remove jdk/jfr/api/consumer/recordingstream/TestOnEvent.java from ProblemList.txt
958786b: 8332522: SwitchBootstraps::mappedEnumLookup constructs unused array
... and 658 more: https://git.openjdk.org/jdk/compare/6238bc8da2abe7a1f0cdd98c0af01e9ba1869ec3...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

openjdk · 2024-07-26T16:55:29Z

@alisenchung The following label will be automatically applied to this pull request:

client

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

kumarabhi006 · 2024-07-30T08:00:58Z

Could you please add a test case to validate the fix ?

test/jdk/javax/swing/JOptionPane/OptionPaneInput.java

honkar-jdk

The test requires clean-up there are couple of commented lines.
JBS issue does not seem to be linked, can you check by adding.
/issue add 8235404
Test summary in jtreg needs an update

test/jdk/javax/swing/JOptionPane/OptionPaneInput.java

mlbridge · 2024-08-01T23:54:02Z

Webrevs

alisenchung · 2024-08-05T17:29:35Z

@kumarabhi006 I've updated the test from your feedback. Could you re-review the changes?

honkar-jdk

Fix looks good except for minor spacing issues.

test/jdk/javax/swing/JOptionPane/OptionPaneInput.java

DamonGuy

Fix itself looks like it's working fine now. I agree to handle the small comment Harshitha left already, but otherwise lgtm.

test/jdk/javax/swing/JOptionPane/OptionPaneInput.java

alisenchung · 2024-08-06T18:23:13Z

/integrate

openjdk · 2024-08-06T18:25:07Z

@alisenchung This pull request has not yet been marked as ready for integration.

honkar-jdk · 2024-08-06T18:49:56Z

test/jdk/javax/swing/JOptionPane/OptionPaneInput.java

+ * published by the Free Software Foundation.  Oracle designates this
+ * particular file as subject to the "Classpath" exception as provided
+ * by Oracle in the LICENSE file that accompanied this code.


Isn't the "Classpath" exception header only applicable to source code files?
Can you please verify with other test file copyright header.

Good catch, I've removed the classpath portion of the copyright. Can you check over the copyright again to make sure it's correct?

honkar-jdk

LGTM

alisenchung · 2024-08-06T21:08:54Z

/integrate

openjdk · 2024-08-06T21:10:06Z

Going to push as commit fc652d2.
Since your change was applied there have been 668 commits pushed to the master branch:

22a3421: 8337786: Fix simple -Wzero-as-null-pointer-constant warnings in aarch64 code
ff634a9: 8337506: Disable "best-fit" mapping on Windows command line
3f8b3e5: 8337887: [JVMCI] Clarify jdk.vm.ci.code.Architecture.getName javadoc
53db937: 8337780: RISC-V: C2: Change C calling convention for sp to NS
ab509f1: 8337654: Relocate uncommon trap stub from SharedRuntime to OptoRuntime
1348ece: 8332120: Potential compilation failure in istream.cpp:205 - loss of data on conversion
ef909bd: 8335121: Native memory leak when not recording any events
a117945: 8337344: Redundant javadoc at RasterPrinterJob.isCancelled
f9b8a22: 8337798: JFR: Remove jdk/jfr/api/consumer/recordingstream/TestOnEvent.java from ProblemList.txt
958786b: 8332522: SwitchBootstraps::mappedEnumLookup constructs unused array
... and 658 more: https://git.openjdk.org/jdk/compare/6238bc8da2abe7a1f0cdd98c0af01e9ba1869ec3...master

Your commit was automatically rebased without conflicts.

openjdk · 2024-08-06T21:10:12Z

@alisenchung Pushed as commit fc652d2.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

init commit

efaa41a

alisenchung marked this pull request as draft July 26, 2024 16:53

openjdk bot added the client client-libs-dev@openjdk.org label Jul 26, 2024

add test

fbc92d1

alisenchung marked this pull request as ready for review July 30, 2024 19:01

kumarabhi006 reviewed Jul 31, 2024

View reviewed changes

honkar-jdk suggested changes Aug 1, 2024

View reviewed changes

test/jdk/javax/swing/JOptionPane/OptionPaneInput.java Outdated Show resolved Hide resolved

honkar-jdk reviewed Aug 1, 2024

View reviewed changes

test/jdk/javax/swing/JOptionPane/OptionPaneInput.java Show resolved Hide resolved

alisenchung changed the title ~~[macos] JOptionPane blocks drawing string on another component~~ 8235404: [macos] JOptionPane blocks drawing string on another component Aug 1, 2024

update test

5742f64

openjdk bot added the rfr Pull request is ready for review label Aug 1, 2024

update test

50fd274

check for null

84d62d5

honkar-jdk approved these changes Aug 5, 2024

View reviewed changes

test/jdk/javax/swing/JOptionPane/OptionPaneInput.java Outdated Show resolved Hide resolved

test/jdk/javax/swing/JOptionPane/OptionPaneInput.java Outdated Show resolved Hide resolved

openjdk bot added the ready Pull request is ready to be integrated label Aug 5, 2024

DamonGuy approved these changes Aug 6, 2024

View reviewed changes

fix spacing

935e988

openjdk bot removed the ready Pull request is ready to be integrated label Aug 6, 2024

honkar-jdk approved these changes Aug 6, 2024

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Aug 6, 2024

turbanoff reviewed Aug 6, 2024

View reviewed changes

test/jdk/javax/swing/JOptionPane/OptionPaneInput.java Outdated Show resolved Hide resolved

space

21696aa

openjdk bot removed the ready Pull request is ready to be integrated label Aug 6, 2024

honkar-jdk suggested changes Aug 6, 2024

View reviewed changes

remove classpath from copyright

930bb81

honkar-jdk approved these changes Aug 6, 2024

View reviewed changes

openjdk bot added the ready Pull request is ready to be integrated label Aug 6, 2024

openjdk bot added the integrated Pull request has been integrated label Aug 6, 2024

openjdk bot closed this Aug 6, 2024

openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Aug 6, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

8235404: [macos] JOptionPane blocks drawing string on another component #20359

8235404: [macos] JOptionPane blocks drawing string on another component #20359

alisenchung commented Jul 26, 2024 •

edited by openjdk bot

Loading

bridgekeeper bot commented Jul 26, 2024

openjdk bot commented Jul 26, 2024 •

edited

Loading

openjdk bot commented Jul 26, 2024

kumarabhi006 commented Jul 30, 2024

honkar-jdk left a comment

mlbridge bot commented Aug 1, 2024 •

edited

Loading

alisenchung commented Aug 5, 2024

honkar-jdk left a comment •

edited

Loading

DamonGuy left a comment

alisenchung commented Aug 6, 2024

openjdk bot commented Aug 6, 2024

honkar-jdk Aug 6, 2024 •

edited

Loading

alisenchung Aug 6, 2024

honkar-jdk left a comment

alisenchung commented Aug 6, 2024

openjdk bot commented Aug 6, 2024

openjdk bot commented Aug 6, 2024

8235404: [macos] JOptionPane blocks drawing string on another component #20359

8235404: [macos] JOptionPane blocks drawing string on another component #20359

Conversation

alisenchung commented Jul 26, 2024 • edited by openjdk bot Loading

Progress

Issue

Reviewers

Reviewing

Webrev

bridgekeeper bot commented Jul 26, 2024

openjdk bot commented Jul 26, 2024 • edited Loading

openjdk bot commented Jul 26, 2024

kumarabhi006 commented Jul 30, 2024

honkar-jdk left a comment

Choose a reason for hiding this comment

mlbridge bot commented Aug 1, 2024 • edited Loading

Webrevs

alisenchung commented Aug 5, 2024

honkar-jdk left a comment • edited Loading

Choose a reason for hiding this comment

DamonGuy left a comment

Choose a reason for hiding this comment

alisenchung commented Aug 6, 2024

openjdk bot commented Aug 6, 2024

honkar-jdk Aug 6, 2024 • edited Loading

Choose a reason for hiding this comment

alisenchung Aug 6, 2024

Choose a reason for hiding this comment

honkar-jdk left a comment

Choose a reason for hiding this comment

alisenchung commented Aug 6, 2024

openjdk bot commented Aug 6, 2024

openjdk bot commented Aug 6, 2024

alisenchung commented Jul 26, 2024 •

edited by openjdk bot

Loading

openjdk bot commented Jul 26, 2024 •

edited

Loading

mlbridge bot commented Aug 1, 2024 •

edited

Loading

honkar-jdk left a comment •

edited

Loading

honkar-jdk Aug 6, 2024 •

edited

Loading