-
Notifications
You must be signed in to change notification settings - Fork 5.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
8335172: Add manual steps to run security/auth/callback/TextCallbackHandler/Password.java test #20374
Conversation
👋 Welcome back fguallini! A progress list of the required criteria for merging this PR into |
@fguallini This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 96 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@rhalade) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
@fguallini this pull request can not be integrated into git checkout 8335172
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push |
@fguallini The following labels will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command. |
/label remove core-libs |
@fguallini |
/integrate |
@fguallini |
/sponsor |
Going to push as commit a5c2d7b.
Your commit was automatically rebased without conflicts. |
@rhalade @fguallini Pushed as commit a5c2d7b. 💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored. |
The test: com/sun/security/auth/callback/TextCallbackHandler/Password.java would benefit from detailed manual steps to ensure it runs correctly. It was added to the problem list because it was not executed properly and failed. Providing these steps will help prevent such issues in the future.
This test cannot be automated because util/Password.java verifies that the given input stream is equal to the initialSystemIn. As a result, the test cannot simulate user input by providing a custom input stream.
Additionally, move it from jdk_security_manual_no_input to jdk_security_manual_interactive because the user needs to enter several passwords and verify the console output. Also, the test was originally introduced in ticket ID: 6829785, added that information.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20374/head:pull/20374
$ git checkout pull/20374
Update a local copy of the PR:
$ git checkout pull/20374
$ git pull https://git.openjdk.org/jdk.git pull/20374/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 20374
View PR using the GUI difftool:
$ git pr show -t 20374
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20374.diff
Webrev
Link to Webrev Comment