Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8335172: Add manual steps to run security/auth/callback/TextCallbackHandler/Password.java test #20374

Closed
wants to merge 3 commits into from

Conversation

fguallini
Copy link
Member

@fguallini fguallini commented Jul 29, 2024

The test: com/sun/security/auth/callback/TextCallbackHandler/Password.java would benefit from detailed manual steps to ensure it runs correctly. It was added to the problem list because it was not executed properly and failed. Providing these steps will help prevent such issues in the future.

This test cannot be automated because util/Password.java verifies that the given input stream is equal to the initialSystemIn. As a result, the test cannot simulate user input by providing a custom input stream.

Additionally, move it from jdk_security_manual_no_input to jdk_security_manual_interactive because the user needs to enter several passwords and verify the console output. Also, the test was originally introduced in ticket ID: 6829785, added that information.


Progress

  • Change must be properly reviewed (1 review required, with at least 1 Reviewer)
  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue

Issue

  • JDK-8335172: Add manual steps to run security/auth/callback/TextCallbackHandler/Password.java test (Bug - P4)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20374/head:pull/20374
$ git checkout pull/20374

Update a local copy of the PR:
$ git checkout pull/20374
$ git pull https://git.openjdk.org/jdk.git pull/20374/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 20374

View PR using the GUI difftool:
$ git pr show -t 20374

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20374.diff

Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Jul 29, 2024

👋 Welcome back fguallini! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jul 29, 2024

@fguallini This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8335172: Add manual steps to run security/auth/callback/TextCallbackHandler/Password.java test

Reviewed-by: rhalade

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 96 new commits pushed to the master branch:

  • 88a05a8: 8337975: [BACKOUT] Native memory leak when not recording any events
  • 41f784f: 8335925: Serial: Move allocation API from Generation to subclasses
  • 66286b2: 8337968: Problem list compiler/vectorapi/VectorRebracket128Test.java
  • 920751e: 8311990: Two JDI tests may interfere with each other
  • 6733b89: 8337667: sun/tools/jcmd/TestJcmdPIDSubstitution.java is failing on mac and windows
  • fc652d2: 8235404: [macos] JOptionPane blocks drawing string on another component
  • 22a3421: 8337786: Fix simple -Wzero-as-null-pointer-constant warnings in aarch64 code
  • ff634a9: 8337506: Disable "best-fit" mapping on Windows command line
  • 3f8b3e5: 8337887: [JVMCI] Clarify jdk.vm.ci.code.Architecture.getName javadoc
  • 53db937: 8337780: RISC-V: C2: Change C calling convention for sp to NS
  • ... and 86 more: https://git.openjdk.org/jdk/compare/cd52ad80a82c8165424722dcddd37d6584137031...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@rhalade) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk
Copy link

openjdk bot commented Jul 29, 2024

@fguallini this pull request can not be integrated into master due to one or more merge conflicts. To resolve these merge conflicts and update this pull request you can run the following commands in the local repository for your personal fork:

git checkout 8335172
git fetch https://git.openjdk.org/jdk.git master
git merge FETCH_HEAD
# resolve conflicts and follow the instructions given by git merge
git commit -m "Merge master"
git push

@openjdk openjdk bot added the merge-conflict Pull request has merge conflict with target branch label Jul 29, 2024
@openjdk
Copy link

openjdk bot commented Jul 29, 2024

@fguallini The following labels will be automatically applied to this pull request:

  • core-libs
  • security

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing lists. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added security security-dev@openjdk.org core-libs core-libs-dev@openjdk.org labels Jul 29, 2024
@fguallini
Copy link
Member Author

/label remove core-libs

@openjdk openjdk bot removed the core-libs core-libs-dev@openjdk.org label Jul 29, 2024
@openjdk
Copy link

openjdk bot commented Jul 29, 2024

@fguallini
The core-libs label was successfully removed.

@openjdk openjdk bot removed the merge-conflict Pull request has merge conflict with target branch label Jul 29, 2024
@fguallini fguallini marked this pull request as ready for review July 29, 2024 14:19
@openjdk openjdk bot added the rfr Pull request is ready for review label Jul 29, 2024
@mlbridge
Copy link

mlbridge bot commented Jul 29, 2024

Webrevs

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Aug 6, 2024
@fguallini
Copy link
Member Author

/integrate

@openjdk openjdk bot added the sponsor Pull request is ready to be sponsored label Aug 7, 2024
@openjdk
Copy link

openjdk bot commented Aug 7, 2024

@fguallini
Your change (at version ffcd5ae) is now ready to be sponsored by a Committer.

@rhalade
Copy link
Member

rhalade commented Aug 7, 2024

/sponsor

@openjdk
Copy link

openjdk bot commented Aug 7, 2024

Going to push as commit a5c2d7b.
Since your change was applied there have been 99 commits pushed to the master branch:

  • 36d08c2: 8336846: assert(state->get_thread() == jt) failed: handshake unsafe conditions
  • d19ba81: 8337603: Change in behavior with -Djava.locale.useOldISOCodes=true
  • 21f710e: 8310675: Fix -Wconversion warnings in ZGC code
  • 88a05a8: 8337975: [BACKOUT] Native memory leak when not recording any events
  • 41f784f: 8335925: Serial: Move allocation API from Generation to subclasses
  • 66286b2: 8337968: Problem list compiler/vectorapi/VectorRebracket128Test.java
  • 920751e: 8311990: Two JDI tests may interfere with each other
  • 6733b89: 8337667: sun/tools/jcmd/TestJcmdPIDSubstitution.java is failing on mac and windows
  • fc652d2: 8235404: [macos] JOptionPane blocks drawing string on another component
  • 22a3421: 8337786: Fix simple -Wzero-as-null-pointer-constant warnings in aarch64 code
  • ... and 89 more: https://git.openjdk.org/jdk/compare/cd52ad80a82c8165424722dcddd37d6584137031...master

Your commit was automatically rebased without conflicts.

@openjdk openjdk bot added the integrated Pull request has been integrated label Aug 7, 2024
@openjdk openjdk bot closed this Aug 7, 2024
@openjdk openjdk bot removed ready Pull request is ready to be integrated rfr Pull request is ready for review sponsor Pull request is ready to be sponsored labels Aug 7, 2024
@openjdk
Copy link

openjdk bot commented Aug 7, 2024

@rhalade @fguallini Pushed as commit a5c2d7b.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integrated Pull request has been integrated security security-dev@openjdk.org
Development

Successfully merging this pull request may close these issues.

2 participants