Skip to content

Conversation

@azuev-java
Copy link
Member

@azuev-java azuev-java commented Jan 11, 2021


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8259585: Accessible actions do not work on mac os x

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2038/head:pull/2038
$ git checkout pull/2038

azuev-java and others added 8 commits October 18, 2020 21:45
Merge changes from master
The JavaAccessibleAction protocol implementation tried to lookup
static java methods getAccessibleActionDescription and doAccessibleAction
as non-static ones and because of that got JNI lookup error.
Changed to a static method lookup and fixed the year in copyrights.
@bridgekeeper
Copy link

bridgekeeper bot commented Jan 11, 2021

👋 Welcome back kizune! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Jan 11, 2021

@azuev-java The following label will be automatically applied to this pull request:

  • awt

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@openjdk openjdk bot added awt client-libs-dev@openjdk.org rfr Pull request is ready for review labels Jan 11, 2021
@mlbridge
Copy link

mlbridge bot commented Jan 11, 2021

Webrevs

@openjdk
Copy link

openjdk bot commented Jan 12, 2021

@azuev-java This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8259585: Accessible actions do not work on mac os x

Reviewed-by: serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 122 new commits pushed to the master branch:

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready Pull request is ready to be integrated label Jan 12, 2021
@azuev-java
Copy link
Member Author

/integrate

@openjdk openjdk bot closed this Jan 12, 2021
@openjdk openjdk bot added integrated Pull request has been integrated and removed ready Pull request is ready to be integrated rfr Pull request is ready for review labels Jan 12, 2021
@openjdk
Copy link

openjdk bot commented Jan 12, 2021

@azuev-java Since your change was applied there have been 122 commits pushed to the master branch:

Your commit was automatically rebased without conflicts.

Pushed as commit b6d51e1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@azuev-java azuev-java deleted the JDK-8259585 branch February 21, 2021 01:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

awt client-libs-dev@openjdk.org integrated Pull request has been integrated

Development

Successfully merging this pull request may close these issues.

2 participants