Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

8259585: Accessible actions do not work on mac os x #2038

Closed
wants to merge 8 commits into from

Conversation

@azuev-java
Copy link
Member

@azuev-java azuev-java commented Jan 11, 2021


Progress

  • Change must not contain extraneous whitespace
  • Commit message must refer to an issue
  • Change must be properly reviewed

Issue

  • JDK-8259585: Accessible actions do not work on mac os x

Reviewers

Download

$ git fetch https://git.openjdk.java.net/jdk pull/2038/head:pull/2038
$ git checkout pull/2038

azuev-java and others added 8 commits Oct 19, 2020
Merge changes from master
The JavaAccessibleAction protocol implementation tried to lookup
static java methods getAccessibleActionDescription and doAccessibleAction
as non-static ones and because of that got JNI lookup error.
Changed to a static method lookup and fixed the year in copyrights.
@bridgekeeper
Copy link

@bridgekeeper bridgekeeper bot commented Jan 11, 2021

👋 Welcome back kizune! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

@openjdk openjdk bot commented Jan 11, 2021

@azuev-java The following label will be automatically applied to this pull request:

  • awt

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

@mlbridge
Copy link

@mlbridge mlbridge bot commented Jan 11, 2021

Webrevs

mrserb
mrserb approved these changes Jan 12, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 12, 2021

@azuev-java This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8259585: Accessible actions do not work on mac os x

Reviewed-by: serb

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 122 new commits pushed to the master branch:

  • 022bc9f: 8258422: Cleanup unnecessary null comparison before instanceof check in java.base
  • ff54b77: 8259439: Apply java.io.Serial annotations in java.datatransfer
  • 712ea25: 8258925: configure script failed on WSL
  • cd73939: 8259528: Broken Link for [java.text.Normalizer.Form]
  • e9929e2: 8259582: Backout JDK-8237578 until all affected tests have been fixed
  • 8dfc77b: 8259586: ProblemList dll_address_to_function_and_library_name
  • d9f2134: 8258655: remove <-- NewPage --> comment from generated pages
  • c956e7a: 8258659: Eliminate whitespace comments from generated pages
  • 3861960: 8258426: Split up autoconf/version-numbers and move it to conf dir
  • dab1787: 8259559: COMPARE_BUILD can't compare patch files
  • ... and 112 more: https://git.openjdk.java.net/jdk/compare/d679caa28d5b2c8e9a385d57323f2f03a77ec1ba...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

@openjdk openjdk bot added the ready label Jan 12, 2021
@azuev-java
Copy link
Member Author

@azuev-java azuev-java commented Jan 12, 2021

/integrate

@openjdk openjdk bot closed this Jan 12, 2021
@openjdk openjdk bot added integrated and removed ready rfr labels Jan 12, 2021
@openjdk
Copy link

@openjdk openjdk bot commented Jan 12, 2021

@azuev-java Since your change was applied there have been 122 commits pushed to the master branch:

  • 022bc9f: 8258422: Cleanup unnecessary null comparison before instanceof check in java.base
  • ff54b77: 8259439: Apply java.io.Serial annotations in java.datatransfer
  • 712ea25: 8258925: configure script failed on WSL
  • cd73939: 8259528: Broken Link for [java.text.Normalizer.Form]
  • e9929e2: 8259582: Backout JDK-8237578 until all affected tests have been fixed
  • 8dfc77b: 8259586: ProblemList dll_address_to_function_and_library_name
  • d9f2134: 8258655: remove <-- NewPage --> comment from generated pages
  • c956e7a: 8258659: Eliminate whitespace comments from generated pages
  • 3861960: 8258426: Split up autoconf/version-numbers and move it to conf dir
  • dab1787: 8259559: COMPARE_BUILD can't compare patch files
  • ... and 112 more: https://git.openjdk.java.net/jdk/compare/d679caa28d5b2c8e9a385d57323f2f03a77ec1ba...master

Your commit was automatically rebased without conflicts.

Pushed as commit b6d51e1.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.

@azuev-java azuev-java deleted the JDK-8259585 branch Feb 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
2 participants