8336462: ConcurrentSkipListSet Javadoc incorrectly warns about size method complexity

[viktorklang-ora]

Removes some of the old wording around the algorithmic complexity of ConcurrentSkipListSet::size() while still retaining the warning around the accuracy of the returned result.

---

Progress

• Change must be properly reviewed (1 review required, with at least 1 Reviewer)
• Change must not contain extraneous whitespace
• Commit message must refer to an issue

Issue

• JDK-8336462: ConcurrentSkipListSet Javadoc incorrectly warns about size method complexity (Bug - P3)

Reviewers

• Jaikiran Pai (@jaikiran - Reviewer)

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/20388/head:pull/20388
$ git checkout pull/20388

Update a local copy of the PR:
$ git checkout pull/20388
$ git pull https://git.openjdk.org/jdk.git pull/20388/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 20388

View PR using the GUI difftool:
$ git pr show -t 20388

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/20388.diff

Webrev

Link to Webrev Comment

[bridgekeeper]

👋 Welcome back vklang! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

[viktorklang-ora]

@DougLea Please let me know what you think about this change. 👍

[openjdk]

@viktorklang-ora This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

8336462: ConcurrentSkipListSet Javadoc incorrectly warns about size method complexity

Reviewed-by: jpai

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been 51 new commits pushed to the master branch:

• be34730: 8335257: Refactor code to create Initialized Assertion Predicates into separate class
• fbe8a81: 8333144: docker tests do not work when ubsan is configured
• dabdae6: 8334599: Improve code from JDK-8302671
• 8bd3cd5: 8337716: ByteBuffer hashCode implementations are inconsistent
• 367e0a6: 8334755: Asymptotically faster implementation of square root algorithm
• 34edc73: 8337396: Cleanup usage of ExternalAddess
• 7deee74: 8335122: Reorganize internal low-level support for HTML in jdk.javadoc
• f2e1205: 8337676: JFR: Change the label of the throttle setting
• 066db6e: 8337274: Remove repeated 'the' in StyleSheet.create{Small,Large}AttributeSet
• 328a053: 8335059: Consider renaming ClassLoaderData::keep_alive
• ... and 41 more: https://git.openjdk.org/jdk/compare/156f0b4332bf076165898417cf6678d2fc32df5c...master

As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details.

➡️ To integrate this PR with the above commit message to the master branch, type /integrate in a new comment.

[openjdk]

@viktorklang-ora The following label will be automatically applied to this pull request:

• core-libs

When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command.

[mlbridge]

Webrevs

• 01: Full - Incremental (c1e02242)
• 00: Full (6240668b)

[DougLea]

Yes, thanks for fixing wording that should have been updated a long time ago.

[viktorklang-ora]

@AlanBateman Would you want to be Reviewer? :)

[jaikiran]

Doug has reviewed this doc-only change and the proposed update to the text looks good to me.

[viktorklang-ora]

@jaikiran Realized the paragraph fell away so I re-added it. Reapproval needed?

[jaikiran]

Hello Viktor, the new review process in the JDK project marks the previous review as stale if a change is done after the approval. Re-review is mandated in such cases. I've now approved the latest change which looks good to me.

[viktorklang-ora]

Thanks @jaikiran 👍

[viktorklang-ora]

/integrate

[openjdk]

Going to push as commit d3e7b0c.
Since your change was applied there have been 51 commits pushed to the master branch:

• be34730: 8335257: Refactor code to create Initialized Assertion Predicates into separate class
• fbe8a81: 8333144: docker tests do not work when ubsan is configured
• dabdae6: 8334599: Improve code from JDK-8302671
• 8bd3cd5: 8337716: ByteBuffer hashCode implementations are inconsistent
• 367e0a6: 8334755: Asymptotically faster implementation of square root algorithm
• 34edc73: 8337396: Cleanup usage of ExternalAddess
• 7deee74: 8335122: Reorganize internal low-level support for HTML in jdk.javadoc
• f2e1205: 8337676: JFR: Change the label of the throttle setting
• 066db6e: 8337274: Remove repeated 'the' in StyleSheet.create{Small,Large}AttributeSet
• 328a053: 8335059: Consider renaming ClassLoaderData::keep_alive
• ... and 41 more: https://git.openjdk.org/jdk/compare/156f0b4332bf076165898417cf6678d2fc32df5c...master

Your commit was automatically rebased without conflicts.

[openjdk]

@viktorklang-ora Pushed as commit d3e7b0c.

💡 You may see a message that your pull request was closed with unmerged commits. This can be safely ignored.